Bug 35180 - Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql
Summary: Fix typo in deletedbiblioitems.publishercode comment in kohastructure.sql
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 34029
Blocks:
  Show dependency tree / graph
 
Reported: 2023-10-29 09:34 UTC by Katrin Fischer
Modified: 2024-07-04 20:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:

Attachments
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode (1.16 KB, patch)
2023-10-29 09:36 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode (1.21 KB, patch)
2023-10-30 01:20 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode (1.26 KB, patch)
2023-10-30 16:16 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-10-29 09:34:17 UTC 
From bug 34029:
(In reply to Fridolin Somers from comment #25)
> There is a small typo in kohastructure.sql :
>   `publishercode` text DEFAULT NULL COMMENT 'publisher (MARC21 260$b and
> 246$b)',
> 
>   246$b => 264$b
> 
> Maybe just fix in master
Comment 1 Katrin Fischer 2023-10-29 09:36:27 UTC 
Created attachment 158022 [details] [review]
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode

This fixes a typo in the comment.

To test:
* Please check diff of the patch closely.
Comment 2 Katrin Fischer 2023-10-29 09:37:03 UTC 
I was not sure if this warranted a database update, but I left it off mostly because I didn't figure out the right syntax to update a comment. If required, some help would be nice :)
Comment 3 David Nind 2023-10-30 01:20:30 UTC 
Created attachment 158056 [details] [review]
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode

This fixes a typo in the comment.

To test:
* Please check diff of the patch closely.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-10-30 01:22:38 UTC 
Testing notes (using KTD):

1. To show the comments column for the table in the database: SHOW FULL COLUMNS FROM biblioitems;

2. To see the updated comments: apply the patch, reset_all, repeat step 1.
Comment 5 Nick Clemens (kidclamp) 2023-10-30 16:16:38 UTC 
Created attachment 158081 [details] [review]
Bug 35180: Fix 246 to 264 in COMMENT of deletedbiblioitems.publishercode

This fixes a typo in the comment.

To test:
* Please check diff of the patch closely.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-10-31 14:06:49 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-11-08 08:27:37 UTC 
Pushed to 23.05.x for 23.05.06
Comment 8 Matt Blenkinsop 2023-11-13 15:29:22 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x