HTML notices don't require that we explicitly add <html> tags. We have 2 notices where these are included in the sample notices and should be removed: PASSWORD_RESET STAFF_PASSWORD_RESET
Created attachment 158048 [details] [review] Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use <html></html>. This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.)
Created attachment 158054 [details] [review] Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use <html></html>. This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind <david@davidnind.com>
Thanks David :)
Testing notes (using KTD): 1. After applying the patch, ran reset_all, so that the notices are updated. 2. Needed to set the OpacResetPassword and KohaAdminEmailAddress system preference. OpacResetPassword required for Patron account > More > Send password reset option to appear. 3. To test sending emails using a Google account: 3.1 Set up an App password in your Google Account 3.2 Edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server>
Created attachment 158079 [details] [review] Bug 35186: Remove unnecessary html tags from PASSWORD notices In HTML notices we don't need to explicitly use <html></html>. This removes them from the 2 notices using them: * PASSWORD_RESET * STAFF_PASSWORD_RESET To test: * Apply patch * Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) * Make sure your patron has an email set * In patron account, use "More > Send password reset" * Log out * In the OPAC, request password reset ("forgot your password?") * Verify both notices appear nicely formatted (line breaks, bold, etc.) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to oldstable for 22.11.x