Bug 35202 - Table settings should apply to multiple subscriptions in the OPAC
Summary: Table settings should apply to multiple subscriptions in the OPAC
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
: 22179 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-10-31 14:07 UTC by Ray Delahunty
Modified: 2025-05-26 07:28 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the display of columns shown for the subscription detail tables in the OPAC, where there are multiple subscriptions for a record. Any changes to the columns were only applied to the first subscription, for all the other subscriptions all the columns were shown (including columns that should have been hidden). (Columns for the subscription tables for the OPAC record details are configured under Administration > Additional parameters > Table settings > OPAC > subscriptionst.)
Version(s) released in:
25.05.00,24.11.05
Circulation function:


Attachments
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC (2.96 KB, patch)
2025-02-07 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC (3.01 KB, patch)
2025-02-08 10:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC (3.06 KB, patch)
2025-02-10 14:49 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC (3.07 KB, patch)
2025-02-12 14:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC (3.16 KB, patch)
2025-02-14 09:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ray Delahunty 2023-10-31 14:07:43 UTC
We have multiple subscriptions for some serials and we have public-inappropriate notes which we want to hide. Editing the subscriptionst view of the subscriptions table in OPAC to hide the serial_notes field should make the serial_notes invisible for all subscriptions. It only vanishes from the first subscription displayed. Other subscriptions expose the serial_note data. Hiding the serial_notes via Table Settings should apply to all subscriptions. Related to Bug 22179? (But the data we have there should be elsewhere, so Bug 33298 interests us).
Comment 1 Ray Delahunty 2023-12-18 13:05:47 UTC
This problem extends to all the fields in table id: subscriptionst, not just the serial_notes.
Comment 2 Owen Leonard 2025-02-07 17:52:25 UTC
Created attachment 177653 [details] [review]
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC

This patch updates the bibliographic detail page in the OPAC so that if
there are multiple subscriptions attached to one record, each table of
issues under the subscriptions tab adheres to the settings defined in
Table Settings.

To test you should have at least two subscriptions attached to one
record, and at least one issue of each subscription.

- Apply the patch and view the record in the OPAC.
- Under the "Subscriptions" tab there should be separate tables for each
  subscription, each of them a sortable DataTable.
- In the staff interface, go to Administration -> Table settings -> OPAC
  -> subscriptionst
  - Select some columns to be hidden by default.
- Return to the OPAC and confirm that each subscription table now
  reflects the change you made in table settings.

Sponsored-by: Athens County Public Libraries
Comment 3 David Nind 2025-02-08 10:42:04 UTC
Created attachment 177660 [details] [review]
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC

This patch updates the bibliographic detail page in the OPAC so that if
there are multiple subscriptions attached to one record, each table of
issues under the subscriptions tab adheres to the settings defined in
Table Settings.

To test you should have at least two subscriptions attached to one
record, and at least one issue of each subscription.

- Apply the patch and view the record in the OPAC.
- Under the "Subscriptions" tab there should be separate tables for each
  subscription, each of them a sortable DataTable.
- In the staff interface, go to Administration -> Table settings -> OPAC
  -> subscriptionst
  - Select some columns to be hidden by default.
- Return to the OPAC and confirm that each subscription table now
  reflects the change you made in table settings.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 PTFS Europe Sandboxes 2025-02-10 14:49:24 UTC
Created attachment 177701 [details] [review]
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC

This patch updates the bibliographic detail page in the OPAC so that if
there are multiple subscriptions attached to one record, each table of
issues under the subscriptions tab adheres to the settings defined in
Table Settings.

To test you should have at least two subscriptions attached to one
record, and at least one issue of each subscription.

- Apply the patch and view the record in the OPAC.
- Under the "Subscriptions" tab there should be separate tables for each
  subscription, each of them a sortable DataTable.
- In the staff interface, go to Administration -> Table settings -> OPAC
  -> subscriptionst
  - Select some columns to be hidden by default.
- Return to the OPAC and confirm that each subscription table now
  reflects the change you made in table settings.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 5 Owen Leonard 2025-02-10 16:13:17 UTC
*** Bug 22179 has been marked as a duplicate of this bug. ***
Comment 6 Owen Leonard 2025-02-12 14:45:56 UTC
Created attachment 177926 [details] [review]
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC

This patch updates the bibliographic detail page in the OPAC so that if
there are multiple subscriptions attached to one record, each table of
issues under the subscriptions tab adheres to the settings defined in
Table Settings.

To test you should have at least two subscriptions attached to one
record, and at least one issue of each subscription.

- Apply the patch and view the record in the OPAC.
- Under the "Subscriptions" tab there should be separate tables for each
  subscription, each of them a sortable DataTable.
- In the staff interface, go to Administration -> Table settings -> OPAC
  -> subscriptionst
  - Select some columns to be hidden by default.
- Return to the OPAC and confirm that each subscription table now
  reflects the change you made in table settings.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 7 Marcel de Rooy 2025-02-14 09:02:13 UTC
Created attachment 178088 [details] [review]
Bug 35202: Table settings should apply to multiple subscriptions in the OPAC

This patch updates the bibliographic detail page in the OPAC so that if
there are multiple subscriptions attached to one record, each table of
issues under the subscriptions tab adheres to the settings defined in
Table Settings.

To test you should have at least two subscriptions attached to one
record, and at least one issue of each subscription.

- Apply the patch and view the record in the OPAC.
- Under the "Subscriptions" tab there should be separate tables for each
  subscription, each of them a sortable DataTable.
- In the staff interface, go to Administration -> Table settings -> OPAC
  -> subscriptionst
  - Select some columns to be hidden by default.
- Return to the OPAC and confirm that each subscription table now
  reflects the change you made in table settings.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Katrin Fischer 2025-02-17 14:07:00 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 9 Ray Delahunty 2025-05-19 08:14:15 UTC
It would be great if this fix could be added to 24.11 as we move to that version in a month (and we won't be on 25.xx until a year from now).
Comment 10 Katrin Fischer 2025-05-20 13:35:49 UTC
We've also run into this while testing. Seconding the wish for backport.
Comment 11 Paul Derscheid 2025-05-26 07:25:00 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.05