Bug 35221 - TrackLastPatronActivityTriggers description is misleading
Summary: TrackLastPatronActivityTriggers description is misleading
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 15504
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-01 20:47 UTC by Caroline Cyr La Rose
Modified: 2023-11-28 13:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35221: TrackLastPatronActivityTriggers description is misleading (2.52 KB, patch)
2023-11-01 21:08 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35221: TrackLastPatronActivityTriggers description is misleading (2.57 KB, patch)
2023-11-01 21:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 35221: TrackLastPatronActivityTriggers description is misleading (2.62 KB, patch)
2023-11-05 01:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-11-01 20:47:10 UTC
The description of the new TrackLastPatronActivityTriggers system preference says "The first time each day that one of these activities occurs, borrowers.lastseen will update with the current date and time." To me, this means that no matter how many times I do one of the actions, the date will not change. However, that is not true. The date is updated on each action of each selected type.

To recreate:
1. Go to Administration > System preferences > TrackLastPatronActivityTriggers
2. Check the "Checking out an item" option
3. Click Save all Patron preferences
4. Go to a patron account
5. Check the date last seen in the database (where X is the patron's borrowernumber)

SELECT lastseen FROM borrowers WHERE borrowernumber = X

5. Check out an item to the patron
6. Check the date last seen, it should have been updated to the checkout date and time
7. Check out a second item to the patron
8. Check the date last seen, it should have been updated to the second checkout date and time
Comment 1 Caroline Cyr La Rose 2023-11-01 21:01:05 UTC
Also, while we're there, could we choose between the present participle tense, the simple present tense and the noun for the options?

Simple present tense
- Places an article request

Present participle tense
- Checking out an item
- Placing a hold on an item
- Renewing an item
- Returning an item --> Should be Checking in an item according to terminology

Noun
- Connection to Koha via SIP or ILSDI
- Login
Comment 2 Caroline Cyr La Rose 2023-11-01 21:08:08 UTC
Created attachment 158212 [details] [review]
Bug 35221: TrackLastPatronActivityTriggers description is misleading

This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day.

This patch also uniformizes the options and corrects terminology for
checking in/returning.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for TrackLastPatronActivityTriggers
4. Read the description, make sure it makes sense and the spelling and
   grammar are correct
5. Open the drop down of options, make sure the spelling and grammar are
   correct
Comment 3 David Nind 2023-11-01 21:34:37 UTC
Created attachment 158220 [details] [review]
Bug 35221: TrackLastPatronActivityTriggers description is misleading

This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day.

This patch also uniformizes the options and corrects terminology for
checking in/returning.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for TrackLastPatronActivityTriggers
4. Read the description, make sure it makes sense and the spelling and
   grammar are correct
5. Open the drop down of options, make sure the spelling and grammar are
   correct

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-11-01 21:35:54 UTC
Thanks Caroline!

I noted this when writing the release note - but you bet me to it!

David
Comment 5 Katrin Fischer 2023-11-05 01:54:18 UTC
Created attachment 158439 [details] [review]
Bug 35221: TrackLastPatronActivityTriggers description is misleading

This patch updates the description for the TrackLastPatronActivityTriggers system preference to specify that each time an action occurs, the date last seen is updated, as opposed to once per day.

This patch also uniformizes the options and corrects terminology for
checking in/returning.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for TrackLastPatronActivityTriggers
4. Read the description, make sure it makes sense and the spelling and
   grammar are correct
5. Open the drop down of options, make sure the spelling and grammar are
   correct

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-11-06 11:40:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-11-10 07:07:16 UTC
Depends on Bug 15504 not in 23.05.x