Bug 35235 - Mismatched label on notice edit form
Summary: Mismatched label on notice edit form
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Haajar Pengelly
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-11-02 17:36 UTC by Owen Leonard
Modified: 2024-11-27 07:53 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:

Attachments
Bug 35235: Make "Koha module" label match the corresponding <select> (1.38 KB, patch)
2024-07-25 23:37 UTC, Koha Training Catalyst 		Details | Diff | Splinter Review
Bug 35235: Make "Koha module" label match the corresponding <select> (1.42 KB, patch)
2024-07-26 18:49 UTC, Sam Lau 		Details | Diff | Splinter Review
Bug 35235: Make "Koha module" label match the corresponding <select> (1.52 KB, patch)
2024-08-02 07:40 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-02 17:36:17 UTC 
Tools -> Notices and slips -> New notice: The "Koha module" label doesn't match the corresponding <select>
Comment 1 Koha Training Catalyst 2024-07-25 23:37:08 UTC Comment hidden (obsolete)
Comment 2 Sam Lau 2024-07-26 18:49:31 UTC 
Created attachment 169773 [details] [review]
Bug 35235: Make "Koha module" label match the corresponding <select>

Test Plan
1. Go to Tools -> Notices and slips -> New notice
2. Select Acquisition
3. Click on the Koha module label
4. The corresponding drop down field should activate (greyed)

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Marcel de Rooy 2024-08-02 07:40:09 UTC 
Created attachment 169989 [details] [review]
Bug 35235: Make "Koha module" label match the corresponding <select>

Test Plan
1. Go to Tools -> Notices and slips -> New notice
2. Select Acquisition
3. Click on the Koha module label
4. The corresponding drop down field should activate (greyed)

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-08-02 17:01:10 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Katrin Fischer 2024-08-02 17:02:01 UTC 
Haajar, you are now officially a Koha developer, congrats! :)
Comment 6 Lucas Gass (lukeg) 2024-09-11 15:54:34 UTC 
Backported to 24.05.x for upcoming 24.05.04
Comment 7 Fridolin Somers 2024-09-25 08:35:35 UTC 
Pushed to 23.11.x for 23.11.09
Comment 8 Wainui Witika-Park 2024-09-27 02:19:44 UTC 
Is this okay to backport during string freeze?
Comment 9 Wainui Witika-Park 2024-11-03 20:49:01 UTC 
Not backporting to 23.05
Comment 10 David Nind 2024-11-27 07:53:51 UTC 
Updated version released in: 25.05.04 to 24.05.04.