Bug 35236 - Mismatched label on patron card batch edit form
Summary: Mismatched label on patron card batch edit form
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jennifer Sutton
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-11-02 17:44 UTC by Owen Leonard
Modified: 2024-09-18 06:38 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Batch description" label when editing a patron card batch (Tools > Patrons and circulation > Patron card creator > Manage > Card batches > Edit). When you click on the batch description label, the input field is now selected and you can enter the batch description. Before this, you had to click in the field to add the description.
Version(s) released in:
24.11.00,24.05.04,23.11.09
Circulation function:


Attachments
Bug 35236: Make "Batch description" label match corresponding <input> field (2.12 KB, patch)
2024-07-25 23:48 UTC, Koha Training Catalyst
Details | Diff | Splinter Review
Bug 35236: Make "Batch description" label match corresponding <input> field (2.17 KB, patch)
2024-07-26 02:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 35236: Make "Batch description" label match corresponding <input> field (2.23 KB, patch)
2024-07-26 13:56 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 35236: Make "Batch description" label match corresponding <input> field (2.26 KB, patch)
2024-07-26 13:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-02 17:44:18 UTC
Tools -> Patron card creator -> Edit batch: The "Batch description" label doesn't match the corresponding <input>
Comment 1 Koha Training Catalyst 2024-07-25 23:48:08 UTC
Created attachment 169629 [details] [review]
Bug 35236: Make "Batch description" label match corresponding <input> field

To test:
  1. Create a new patron.
  2. Go to Tools -> Patron card creator.
  3. Create a new patron card batch.
  4. On the "Edit patron card batch" page, click the "Batch
     description:" label.
  5. Observe that the corresponding <input> field is selected.
Comment 2 David Nind 2024-07-26 02:25:54 UTC
Created attachment 169636 [details] [review]
Bug 35236: Make "Batch description" label match corresponding <input> field

To test:
  1. Create a new patron.
  2. Go to Tools -> Patron card creator.
  3. Create a new patron card batch.
  4. On the "Edit patron card batch" page, click the "Batch
     description:" label.
  5. Observe that the corresponding <input> field is selected.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-07-26 02:35:30 UTC
It took me a while to work out what was changed 8-).

Now signed off, and a draft release note added.

David Nind
Comment 4 Martin Renvoize (ashimema) 2024-07-26 13:56:10 UTC
Created attachment 169724 [details] [review]
Bug 35236: Make "Batch description" label match corresponding <input> field

To test:
  1. Create a new patron.
  2. Go to Tools -> Patron card creator.
  3. Create a new patron card batch.
  4. On the "Edit patron card batch" page, click the "Batch
     description:" label.
  5. Observe that the corresponding <input> field is selected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-07-26 13:57:26 UTC
Created attachment 169725 [details] [review]
Bug 35236: Make "Batch description" label match corresponding <input> field

To test:
  1. Create a new patron.
  2. Go to Tools -> Patron card creator.
  3. Create a new patron card batch.
  4. On the "Edit patron card batch" page, click the "Batch
     description:" label.
  5. Observe that the corresponding <input> field is selected.

Mentored-by: Catalyst Academy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-07-26 16:05:26 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-08-29 17:04:03 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 8 Fridolin Somers 2024-09-16 14:03:27 UTC
Pushed to 23.11.x for 23.11.09
Comment 9 Wainui Witika-Park 2024-09-18 06:38:17 UTC
Not backporting to 23.05.x unless requested