Bug 35239 - Missing form field ids in batch patron modification template
Summary: Missing form field ids in batch patron modification template
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy, accessibility
Depends on:
Blocks:
 
Reported: 2023-11-02 18:09 UTC by Owen Leonard
Modified: 2024-11-15 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the batch patron modification edit form labels so that they all have IDs, and the input box now receive the focus when clicking on the label (this includes patron attribute fields, but excludes date fields). This is an accessibility improvement. Before this, you had to click in the input box to add a value.
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 35239: Missing form field ids in batch patron modification template (1.49 KB, patch)
2024-07-25 23:31 UTC, Koha Training Catalyst 		Details | Diff | Splinter Review
Bug 35239: Missing form field ids in batch patron modification template (1.57 KB, patch)
2024-07-26 18:52 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35239: (follow-up) Correct more missing label inconsistencies (4.16 KB, patch)
2024-07-26 18:52 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 35239: Missing form field ids in batch patron modification template (1.61 KB, patch)
2024-07-28 00:09 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35239: (follow-up) Correct more missing label inconsistencies (4.20 KB, patch)
2024-07-28 00:09 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-02 18:09:50 UTC 
Tools -> Batch patron modification -> Modifications (after submitting a batch of patrons):

The edit form already has valid labels but not all the form fields have matching ids.

There is also a markup error, a missing "=" in this tag:

<input type"hidden" name="patron_attributes_value" />
Comment 1 Koha Training Catalyst 2024-07-25 23:31:47 UTC 
Created attachment 169627 [details] [review]
Bug 35239: Missing form field ids in batch patron modification template

Test Plan
1. Tools > Batch patron modification
2. List valid card number in text box
3. [Continue]
4. Edit patrons form, click on input box label
5. Matching input box gets focus
Comment 2 Owen Leonard 2024-07-26 18:52:52 UTC 
Created attachment 169774 [details] [review]
Bug 35239: Missing form field ids in batch patron modification template

Test Plan
1. Tools > Batch patron modification
2. List valid card number in text box
3. [Continue]
4. Edit patrons form, click on input box label
5. Matching input box gets focus

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2024-07-26 18:52:54 UTC 
Created attachment 169775 [details] [review]
Bug 35239: (follow-up) Correct more missing label inconsistencies

This patch corrects a couple more labels and modifies the process of
cloning a patron attribute field so that each new cloned row has
matching label and input.

To test, apply the patch and, if necessary, create some patron attribute
types:

- Go to Administration -> Patron attribute types
- Create at least two new patron attribute types.
- Go to Tools -> Batch patron modification.
- Submit a batch of patrons for batch modification
- In the list of fields to modify, test that clicking each label gives
  focus to the corresponding field (except date fields, we need to fix
  that globally).
- Click "New" next to the patron attribute field.
  - A copy of the field should be created. Test that the new field also
    has matching label and <select>

Sponsored-by: Athens County Public Libraries
Comment 4 David Nind 2024-07-28 00:09:06 UTC 
Created attachment 169797 [details] [review]
Bug 35239: Missing form field ids in batch patron modification template

Test Plan
1. Tools > Batch patron modification
2. List valid card number in text box
3. [Continue]
4. Edit patrons form, click on input box label
5. Matching input box gets focus

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-07-28 00:09:09 UTC 
Created attachment 169798 [details] [review]
Bug 35239: (follow-up) Correct more missing label inconsistencies

This patch corrects a couple more labels and modifies the process of
cloning a patron attribute field so that each new cloned row has
matching label and input.

To test, apply the patch and, if necessary, create some patron attribute
types:

- Go to Administration -> Patron attribute types
- Create at least two new patron attribute types.
- Go to Tools -> Batch patron modification.
- Submit a batch of patrons for batch modification
- In the list of fields to modify, test that clicking each label gives
  focus to the corresponding field (except date fields, we need to fix
  that globally).
- Click "New" next to the patron attribute field.
  - A copy of the field should be created. Test that the new field also
    has matching label and <select>

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Katrin Fischer 2024-09-02 08:26:26 UTC 
QA'd by RM.
Comment 7 Katrin Fischer 2024-09-02 10:21:13 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Lucas Gass (lukeg) 2024-11-15 20:37:20 UTC 
Backported to 24.05.x for upcoming 24.05.06