Bug 35257 - Only admin start page uses "circulation desks"
Summary: Only admin start page uses "circulation desks"
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2023-11-04 17:48 UTC by Katrin Fischer
Modified: 2024-06-12 12:41 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This changes the Koha administration page title for "Circulation desks" to "Desks" for consistency - all other areas such as the sidebar, page titles, and breadcrumbs all use just "Desks". It also updates the UseCirculationDesks system preference description.
Version(s) released in:


Attachments
Bug 35257: Change 'Circulation desks' to 'Desks' (2.93 KB, patch)
2024-06-08 06:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 35257: Change 'Circulation desks' to 'Desks' (2.99 KB, patch)
2024-06-12 12:40 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-04 17:48:29 UTC
In the sidebar and on the desk admin page, we only use "Desks". The administration start page seems to be the only place that uses the term "circulation desk".
Comment 1 David Nind 2024-06-08 06:47:43 UTC
Created attachment 167594 [details] [review]
Bug 35257: Change 'Circulation desks' to 'Desks'

The administration page is the only page that uses "Circulation desks" for
navigation elements. All other areas (sidebar menu, breadcrumbs,
adding and editing desks, page titles) all use just "Desks".

This updates the Koha administration page to use "desks" for consistency. It
also updates the UseCirculationDesks system preference description.

Test plan:
1. Enable the UseCirculationDesks system preference.
2. Go to Koha administration > Patrons and circulation
3. Select the Circulation desks option.
4. Note that the sidebar menu, breadcrumbs, and page titles all
   use just "Desks".
5. Note that in the top-right hand menu bar that it says "NO DESK SET". If
   you click the dropdown menu it says "Set library and desk".
6. Apply the patch.
7. Go to Koha administartion > Patrons and circulation.
8. Note that the heading now says just "Desks".
9. Note that the description for the UseCirculationDesks system
   preference is now "Don't use/Use circulation desks".
10. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Pedro Amorim 2024-06-12 12:40:29 UTC
Created attachment 167654 [details] [review]
Bug 35257: Change 'Circulation desks' to 'Desks'

The administration page is the only page that uses "Circulation desks" for
navigation elements. All other areas (sidebar menu, breadcrumbs,
adding and editing desks, page titles) all use just "Desks".

This updates the Koha administration page to use "desks" for consistency. It
also updates the UseCirculationDesks system preference description.

Test plan:
1. Enable the UseCirculationDesks system preference.
2. Go to Koha administration > Patrons and circulation
3. Select the Circulation desks option.
4. Note that the sidebar menu, breadcrumbs, and page titles all
   use just "Desks".
5. Note that in the top-right hand menu bar that it says "NO DESK SET". If
   you click the dropdown menu it says "Set library and desk".
6. Apply the patch.
7. Go to Koha administartion > Patrons and circulation.
8. Note that the heading now says just "Desks".
9. Note that the description for the UseCirculationDesks system
   preference is now "Don't use/Use circulation desks".
10. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2024-06-12 12:41:14 UTC
$ git grep "circulation desk"

Shows a few more occurrences of this. Don't know if intentional or not, just fyi.