Bug 35286 - Replace GetPrintMessages with Koha::Notice::Messages->search
Summary: Replace GetPrintMessages with Koha::Notice::Messages->search
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35285
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-08 10:30 UTC by Martin Renvoize (ashimema)
Modified: 2023-11-08 10:53 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2023-11-08 10:30:55 UTC 
C4::Letters::GetPrintMessages is a very basic wrapper around a simple SQL lookup. We could easily remove it and use Koha::Notice::Messages->search directly instead resulting in Koha::Notice::Message objects in the return.
Comment 1 Martin Renvoize (ashimema) 2023-11-08 10:53:08 UTC 
The reason to do this would be to use the methods introduced in bug 35285 so we're consistent with how we output print notices in the browser from the staff client and more directly as the output of gather_print_notices.