See also bug 31665. Remove focus handler from dateaccessioned plugin. The onOpen from flatpickr has control now.
Created attachment 158702 [details] [review] Bug 35298: Remove focus handler from dateaccessioned plugin. Test plan: Verify that setting focus to date acquired field in items editor fills date of today when field is empty but does not replace existing date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Super trivial: self SO
Created attachment 158711 [details] [review] Bug 35298: Remove focus handler from dateaccessioned plugin. Test plan: Verify that setting focus to date acquired field in items editor fills date of today when field is empty but does not replace existing date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I tried to test, but setting the focus in the field already pre-fills the date for me without applying this patch. I tried clicking in the field and "tabbing" to it. Tested in Firefox.
Back to Signed off. This is just confusion about the expected results.
(In reply to Katrin Fischer from comment #4) > I tried to test, but setting the focus in the field already pre-fills the > date for me without applying this patch. Yes, but that is just Flatpickr. The removed focus handler simply does nothing.
Created attachment 158811 [details] [review] Bug 35298: Remove focus handler from dateaccessioned plugin. Test plan: Verify that setting focus to date acquired field in items editor fills date of today when field is empty but does not replace existing date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to oldstable for 22.11.x