Bug 35309 - Remove DT's fnSetFilteringDelay
Summary: Remove DT's fnSetFilteringDelay
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35284
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-10 08:40 UTC by Jonathan Druart
Modified: 2024-01-04 20:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Circulation function:


Attachments
Bug 35309: Remove DT's fnSetFilteringDelay (3.36 KB, patch)
2023-11-15 10:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35309: Remove DT's fnSetFilteringDelay (3.42 KB, patch)
2023-11-15 23:13 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35309: Remove DT's fnSetFilteringDelay (3.51 KB, patch)
2023-11-24 07:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-11-10 08:40:55 UTC
See bug 35284, fnSetFilteringDelay is no longer working and should be removed.

However it's used in fnAddFilters which is used in different places that certainly need to be adjusted (using searchDelay? simply removing the delay?)
Comment 1 Jonathan Druart 2023-11-15 10:48:10 UTC
Created attachment 158978 [details] [review]
Bug 35309: Remove DT's fnSetFilteringDelay

On bug 35284 we added the delay on the column filters using dt's
throttle builtin function.

From doc:
https://datatables.net/plug-ins/api/fnSetFilteringDelay
"""
Please note that this plug-in has been deprecated and the dt-init searchDelay option in DataTables 1.10 should now be used. This plug-in will not operate with v1.10+.

Test plan:
Note that column filtering still work as before (test on different
tables, see bug 35284 for the list)
Comment 2 Lucas Gass (lukeg) 2023-11-15 23:13:18 UTC
Created attachment 159018 [details] [review]
Bug 35309: Remove DT's fnSetFilteringDelay

On bug 35284 we added the delay on the column filters using dt's
throttle builtin function.

From doc:
https://datatables.net/plug-ins/api/fnSetFilteringDelay
"""
Please note that this plug-in has been deprecated and the dt-init searchDelay option in DataTables 1.10 should now be used. This plug-in will not operate with v1.10+.

Test plan:
Note that column filtering still work as before (test on different
tables, see bug 35284 for the list)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Marcel de Rooy 2023-11-17 07:29:15 UTC
(In reply to Jonathan Druart from comment #0)
> See bug 35284, fnSetFilteringDelay is no longer working and should be
> removed.

Okay.

> However it's used in fnAddFilters which is used in different places that
> certainly need to be adjusted (using searchDelay? simply removing the delay?)

And now?
Comment 4 Jonathan Druart 2023-11-17 08:53:23 UTC
The delay is still used for colum filters.
Global search is limited by searchDelay
Comment 5 Marcel de Rooy 2023-11-24 07:32:43 UTC
Created attachment 159228 [details] [review]
Bug 35309: Remove DT's fnSetFilteringDelay

On bug 35284 we added the delay on the column filters using dt's
throttle builtin function.

From doc:
https://datatables.net/plug-ins/api/fnSetFilteringDelay
"""
Please note that this plug-in has been deprecated and the dt-init searchDelay option in DataTables 1.10 should now be used. This plug-in will not operate with v1.10+.

Test plan:
Note that column filtering still work as before (test on different
tables, see bug 35284 for the list)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2023-12-19 12:44:07 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 14:57:17 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass (lukeg) 2024-01-04 20:32:50 UTC
Backported to 23.05.x for upcoming 23.05.08