Bug 35343 - record method, required for bug 26611, missing from Koha::Authority
Summary: record method, required for bug 26611, missing from Koha::Authority
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low major (vote)
Assignee: Martin Renvoize
QA Contact: Martin Renvoize
URL:
Keywords: rel_22_05_candidate
Depends on: 26611
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-15 17:05 UTC by Martin Renvoize
Modified: 2024-01-29 22:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.12, 22.05.18


Attachments
Bug 35343: Add record accessor method to Koha::Authority (3.50 KB, patch)
2023-11-15 17:14 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-11-15 17:05:52 UTC
Bug 26611 was backported to 22.11.x, but missed that Koha::Authority->record was added in bug 31794.

We need the record method adding for 22.11 to prevent code explosions when matches are found.
Comment 1 Martin Renvoize 2023-11-15 17:14:49 UTC
Created attachment 159001 [details] [review]
Bug 35343: Add record accessor method to Koha::Authority

Code lifted from bug 31794 to fix already backported bug 26611.

Unit tests included.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 2 Martin Renvoize 2023-11-15 17:17:22 UTC
Testing on customer site to double-check the work then will pass directly to the 22.11.x rmaints.
Comment 3 Martin Renvoize 2023-11-15 18:46:37 UTC
Confirmed no regressions introduced.
Comment 4 Matt Blenkinsop 2023-11-16 09:09:59 UTC
Backported to 22.11.x - thanks Martin
Comment 5 Martin Renvoize 2023-11-16 11:40:30 UTC
Marking RESOLVED FIXED.. this won't be needed for 22.05.x series (already resolved there in a different follow-up).. and it's a bugfix that doesn't need documenting.
Comment 6 Aleisha Amohia 2024-01-24 01:05:13 UTC
(In reply to Martin Renvoize from comment #5)
> Marking RESOLVED FIXED.. this won't be needed for 22.05.x series (already
> resolved there in a different follow-up).. and it's a bugfix that doesn't
> need documenting.

We've discovered this fix is needed for 22.05, the 22.05 patch on Bug 26611 wasn't applied, so this one will need to be backported
Comment 7 wainuiwitikapark 2024-01-24 08:33:27 UTC
Backported to 22.05.x