The system preference, emaillibrarianwhenholdisplaced, states, "sending an email to the Koha administrator email address whenever a hold request is placed". However, this will be sent to the library's email address if they are set up in Libraries . The fact that Koha says the email gets sent out to the Koha Admin Email would not be helpful for multi-site libraries within Koha. With more in the system preference, libraries could know more about how this will work for their set up.
# Send e-mail to librarian if syspref is active if(C4::Context->preference("emailLibrarianWhenHoldIsPlaced")){ my $patron = $hold->patron; my $library = $patron->library; if ( my $letter = C4::Letters::GetPreparedLetter ( module => 'reserves', letter_code => 'HOLDPLACED', branchcode => $branch, lang => $patron->lang, tables => { 'branches' => $library->unblessed, 'borrowers' => $patron->unblessed, 'biblio' => $biblionumber, 'biblioitems' => $biblionumber, 'items' => $checkitem, 'reserves' => $hold->unblessed, }, ) ) { my $branch_email_address = $library->inbound_email_address; C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $borrowernumber, message_transport_type => 'email', to_address => $branch_email_address, } ); } }
Created attachment 161014 [details] [review] Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected
Created attachment 161103 [details] [review] Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected Signed-off-by: David Nind <david@davidnind.com>
Created attachment 161309 [details] [review] Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Note that system preference real name is : emailLibrarianWhenHoldIsPlaced
Backported to 23.05.x for upcoming 23.05.09