If you go to circ/waitingreserves.pl there are 3 tabs: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. It would be nice if things were a bit more consistent.
Also a form element ( cancelAllReserve ) cannot be a child element of a span ( #holdsover-cancel-all ). That creates invalid HTML.
Created attachment 159779 [details] [review] Bug 35360: Make HTML/buttons consistent on waitingreserves.tt To test: 1. Have some holds that are waiting, waiting over expiration date, and cancelled waiting holds. 2. Notice the differences between the 3 tables and their related buttons: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. 3. APPLY PATCH 4. Look again and the tables/buttons should be more consistent. 5. The 'Holds with cancellation requests: X' tab should now include a 'Cancel selected (X)' button. Make sure is works. 6. Turn on TransferWhenCancelAllWaitingHolds and make sure the hint displays well in the Holds over table.
Created attachment 159833 [details] [review] Bug 35360: Make HTML/buttons consistent on waitingreserves.tt To test: 0. Turn on hold cancellation requests in Administration -> Circulation rules. 1. Have some holds that are waiting, waiting over expiration date, and cancelled waiting holds. In order to create holds waiting over expiration date, if you are in ktd, you can use SQL to update the expirationdate in reserves: UPDATE reserves SET expirationdate="2022-01-01" WHERE reserve_id=1; (make sure it's the correct reserve_id!) 1a. If you are not using ktd, you will need to set ReservesMaxPickUpDelay to 0 days, then return the reserved item and then wait one day before it will be marked as over expiration date. 1b. In order to create cancelled waiting holds, you will need to send a cancel request over the OPAC, that is, reserve something after logging in to the OPAC, return it in the staff interface, and then go to the OPAC -> Your Account -> Holds -> click Cancel on the waiting hold. 2. Notice the differences between the 3 tables and their related buttons: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. 3. APPLY PATCH 4. Look again and the tables/buttons should be more consistent. 5. The 'Holds with cancellation requests: X' tab should now include a 'Cancel selected (X)' button. Make sure is works. 6. Make sure TransferWhenCancelAllWaitingHolds is set to "Don't transfer" and make sure the hint displays well in the Holds over table. Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
I fixed the test plan to include extra steps to explain how to create hold cancellation requests and also for displaying the hint when TransferWhenCancelAllWaitingHolds is set to "Don't Transfer", not to "Transfer".
old test plan: > 6. Turn on TransferWhenCancelAllWaitingHolds and make sure the hint displays well in the Holds over table. From our understanding, it's the opposite. So test plan was changed to fix this.
Lucas, on the 'Holds waiting past their expiration date' tab there's the extra 'Cancell all' button, which ends up too close to the 'Cancel selected' one. Can you please amend the patch to make it have some default padding we might use everywhere between them? Thanks!
Created attachment 159945 [details] Screenshot
Created attachment 160010 [details] [review] Bug 35360: Make HTML/buttons consistent on waitingreserves.tt To test: 0. Turn on hold cancellation requests in Administration -> Circulation rules. 1. Have some holds that are waiting, waiting over expiration date, and cancelled waiting holds. In order to create holds waiting over expiration date, if you are in ktd, you can use SQL to update the expirationdate in reserves: UPDATE reserves SET expirationdate="2022-01-01" WHERE reserve_id=1; (make sure it's the correct reserve_id!) 1a. If you are not using ktd, you will need to set ReservesMaxPickUpDelay to 0 days, then return the reserved item and then wait one day before it will be marked as over expiration date. 1b. In order to create cancelled waiting holds, you will need to send a cancel request over the OPAC, that is, reserve something after logging in to the OPAC, return it in the staff interface, and then go to the OPAC -> Your Account -> Holds -> click Cancel on the waiting hold. 2. Notice the differences between the 3 tables and their related buttons: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. 3. APPLY PATCH 4. Look again and the tables/buttons should be more consistent. 5. The 'Holds with cancellation requests: X' tab should now include a 'Cancel selected (X)' button. Make sure is works. 6. Make sure TransferWhenCancelAllWaitingHolds is set to "Don't transfer" and make sure the hint displays well in the Holds over table. Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
(In reply to Tomás Cohen Arazi from comment #6) > Lucas, on the 'Holds waiting past their expiration date' tab there's the > extra 'Cancell all' button, which ends up too close to the 'Cancel selected' > one. Can you please amend the patch to make it have some default padding we > might use everywhere between them? Thanks! Thanks Tomas. There is a form called cancelAllReserve, I wrapped it in the Bootstrap btn-group class as I think that is the way to solve the issue.
Created attachment 161205 [details] [review] Bug 35360: Make HTML/buttons consistent on waitingreserves.tt To test: 0. Turn on hold cancellation requests in Administration -> Circulation rules. 1. Have some holds that are waiting, waiting over expiration date, and cancelled waiting holds. In order to create holds waiting over expiration date, if you are in ktd, you can use SQL to update the expirationdate in reserves: UPDATE reserves SET expirationdate="2022-01-01" WHERE reserve_id=1; (make sure it's the correct reserve_id!) 1a. If you are not using ktd, you will need to set ReservesMaxPickUpDelay to 0 days, then return the reserved item and then wait one day before it will be marked as over expiration date. 1b. In order to create cancelled waiting holds, you will need to send a cancel request over the OPAC, that is, reserve something after logging in to the OPAC, return it in the staff interface, and then go to the OPAC -> Your Account -> Holds -> click Cancel on the waiting hold. 2. Notice the differences between the 3 tables and their related buttons: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. 3. APPLY PATCH 4. Look again and the tables/buttons should be more consistent. 5. The 'Holds with cancellation requests: X' tab should now include a 'Cancel selected (X)' button. Make sure is works. 6. Make sure TransferWhenCancelAllWaitingHolds is set to "Don't transfer" and make sure the hint displays well in the Holds over table. Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Backported to 23.05.x for upcoming 23.05.09