https://api.koha-community.org/Development.html#tag/checkouts/operation/addCheckout https://api.koha-community.org/Development.html#tag/checkouts/operation/addCheckoutPublic I think we should add (public) to one of the headings. ... also should we maybe have it read: "check out an item"?
Created attachment 161013 [details] [review] Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser.
Created attachment 161353 [details] [review] Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 161561 [details] [review] Bug 35368: Add public to "Add a new checkout" in API documentation Without this patch the "Add a new checkout" label showed up twice in the Checkouts section of the API documentation. This adds (public) to the end of one, to make it possible to distinguish them. To test (ON YOUR HOST MACHINE): 1. Run: $ cd api/v1/swagger $ docker run --rm -v $(pwd):/api --workdir /api redocly/cli \ build-docs swagger.yaml --output index.html 2. Open the generated index.html in your browser 3. Verify doubled up headings 4. Apply patch 5. Re-run docker command form 1. 6. Verify there are now 2 different labels and "(public)" is on the right one. Note: if you have wrong permissions on the file, chown it to your own user to open it in the browser. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03