The first sentence here doen't read quite right: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:447 Some patrons have requested a privacy on returning item, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail. Also: Returning should be checking in
How about: Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail.
Sounds better to me :)
Created attachment 159447 [details] [review] Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail."
Created attachment 159453 [details] [review] Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 159631 [details] [review] Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.01
Not needed in 23.05.x, no backport.