One endpoint for stockrotation already exists and was an early addition to the REST api's. We aught to complete the set and add endpoints for fetching and working with rota's.
Created attachment 159357 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory.
Created attachment 159358 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints
Created attachment 159359 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's.
Test plan.. run the included unit tests and ensure they pass ;P
Created attachment 159360 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory.
Created attachment 159361 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints
Created attachment 159362 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's.
This is especially useful as it is for EDI users using the LRP segment to auto-populate rotation plans on ordering. Vendors could use the Fetch API to populate the LRP options pick list in their portals.
Created attachment 159418 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159419 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159420 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. After apply the patch, run the new tests - these should pass: prove t/db_dependent/api/v1/stockrotation_rotas.t
Created attachment 164134 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 164135 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 164136 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I am sorry, unit tests are failing, can you please have a look? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t KO! # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 88. # Structures begin differing at: # $got->[2] = HASH(0x56028e088858) # $expected->[2] = Does not exist # Looks like you failed 1 test of 20. # Failed test 'list() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 102. # Looks like you failed 1 test of 5. /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests
1538 commits since I last rebased the patch.. not all that surprising.
Created attachment 165538 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 165539 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 165540 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 165541 [details] [review] Bug 35430: (follow-up) Remove 'me' from query in tests
I have a failing test with this patch set applied, please check! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t KO! # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 88. # Structures begin differing at: # $got->[2] = HASH(0x55687bdd94d8) # $expected->[2] = Does not exist # Looks like you failed 1 test of 20. # Failed test 'list() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 102. # Looks like you failed 1 test of 5. /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests
I don't understand this failure.. I have "me." In the query and it passes sometimes fails others.. I remove the "me." And it passes sometimes, fails others. Any thoughts Tomas, I'm stuck
Created attachment 168202 [details] [review] Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 168203 [details] [review] Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 168204 [details] [review] Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
It wasn't the 'me' at all.. it was the mocked object call. Anyway.. it works consistently now.
Pushed for 24.11! Well done everyone, thank you!