Bug 35430 - Add endpoints for managing stock rotation rota's
Summary: Add endpoints for managing stock rotation rota's
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 11897
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-29 11:51 UTC by Martin Renvoize
Modified: 2024-03-29 13:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds API endpoints for managing stock rotation rotas.
Version(s) released in:


Attachments
Bug 35430: Move 'Stage' into StockRotation directory (1.34 KB, patch)
2023-11-29 17:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Add unit tests for new stockrotation endpoints (12.39 KB, patch)
2023-11-29 17:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Add rota endpoints for stockrotation (12.37 KB, patch)
2023-11-29 17:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Move 'Stage' into StockRotation directory (1.34 KB, patch)
2023-11-29 17:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Add unit tests for new stockrotation endpoints (12.19 KB, patch)
2023-11-29 17:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Add rota endpoints for stockrotation (12.38 KB, patch)
2023-11-29 17:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35430: Move 'Stage' into StockRotation directory (1.39 KB, patch)
2023-11-30 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 35430: Add unit tests for new stockrotation endpoints (12.24 KB, patch)
2023-11-30 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 35430: Add rota endpoints for stockrotation (12.42 KB, patch)
2023-11-30 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 35430: Move 'Stage' into StockRotation directory (1.45 KB, patch)
2024-03-29 13:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 35430: Add unit tests for new stockrotation endpoints (12.30 KB, patch)
2024-03-29 13:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 35430: Add rota endpoints for stockrotation (12.48 KB, patch)
2024-03-29 13:53 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-11-29 11:51:27 UTC
One endpoint for stockrotation already exists and was an early addition to the REST api's.

We aught to complete the set and add endpoints for fetching and working with rota's.
Comment 1 Martin Renvoize 2023-11-29 17:36:16 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-11-29 17:36:18 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2023-11-29 17:36:21 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2023-11-29 17:37:28 UTC
Test plan.. run the included unit tests and ensure they pass ;P
Comment 5 Martin Renvoize 2023-11-29 17:40:09 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize 2023-11-29 17:40:12 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize 2023-11-29 17:40:14 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2023-11-30 13:59:10 UTC
This is especially useful as it is for EDI users using the LRP segment to auto-populate rotation plans on ordering.

Vendors could use the Fetch API to populate the LRP options pick list in their portals.
Comment 9 David Nind 2023-11-30 18:54:00 UTC
Created attachment 159418 [details] [review]
Bug 35430: Move 'Stage' into StockRotation directory

Cleaning up a little, I opt to move the 'Stage' controller under a new
StockRotation parent directory.

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2023-11-30 18:54:02 UTC
Created attachment 159419 [details] [review]
Bug 35430: Add unit tests for new stockrotation endpoints

Signed-off-by: David Nind <david@davidnind.com>
Comment 11 David Nind 2023-11-30 18:54:05 UTC
Created attachment 159420 [details] [review]
Bug 35430: Add rota endpoints for stockrotation

This patch adds the CRUD endpoints for stock rotation rota's.

Signed-off-by: David Nind <david@davidnind.com>
Comment 12 David Nind 2023-11-30 18:57:14 UTC
Testing notes (using KTD):

1. After apply the patch, run the new tests - these should pass: 
   prove t/db_dependent/api/v1/stockrotation_rotas.t
Comment 13 Kyle M Hall 2024-03-29 13:53:17 UTC
Created attachment 164134 [details] [review]
Bug 35430: Move 'Stage' into StockRotation directory

Cleaning up a little, I opt to move the 'Stage' controller under a new
StockRotation parent directory.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Kyle M Hall 2024-03-29 13:53:23 UTC
Created attachment 164135 [details] [review]
Bug 35430: Add unit tests for new stockrotation endpoints

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 15 Kyle M Hall 2024-03-29 13:53:25 UTC
Created attachment 164136 [details] [review]
Bug 35430: Add rota endpoints for stockrotation

This patch adds the CRUD endpoints for stock rotation rota's.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>