We have some "here" links that slipped into system preference descriptions: Example: UpdateItemLocationOnCheckin <br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>.
Is UpdateItemLocationOnCheckin correct? I don't see 'here' in that pref's description. However: kohadev-koha@kohadevbox:preferences(master)$ git grep '>here' opac.pref: - "<br><strong>NOTE:</strong> Library specific JS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>." opac.pref: - "<br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>." The two places I am seeing is OPACUserJS and OPACUserCSS.
You are right, copy and paste from a wrong tab. Only the 2 to fix.
Created attachment 159464 [details] [review] Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page.
Created attachment 159481 [details] [review] Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159665 [details] [review] Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.01
Not needed in 23.05.x, no backport.