Bug 35454 - A bad RENEWAL notice breaks the ability to renew items
Summary: A bad RENEWAL notice breaks the ability to renew items
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-30 16:01 UTC by Lucas Gass (lukeg)
Modified: 2023-12-01 14:52 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-11-30 16:01:44 UTC 
To recreate:

1. Have an errouneous template in your RENEWAL notice. For  example this template is missing an [% END %]:

[% UNLESS  borrower.branchcode == "ABC" %]
The following items have been renewed:
----
<<biblio.title>>
----

2. Have  RenewalSendNotice set to 'Send'
3. Make sure a patron has the 'Item checkout' messaging pref set. 
4. Checkout some items to that patron and try to renew them.
5. Nothing happens.
6. Fix the notice by adding the missing [% END %]
7. Now you can successfully renew.


Bad templates should not complete break the ability to renew items.