To recreate: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page
Created attachment 159600 [details] [review] Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows
Created attachment 159608 [details] [review] Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows Signed-off-by: David Nind <david@davidnind.com>
I've signed off, as it does what it says in the test plan. Should the rules be in the system preference? That is: if an option for CollapseFieldsPatronAddForm is "not valid", for example like housebound roles that requires HouseboundModule, then it is greyed out/not able to be selected?
Created attachment 160009 [details] [review] Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial patch working as designed. No regressions, QA scripts happy. Passing QA Whilst I agree with David, it would be nice if the sysprefs themselves were a bit more reactive to the value's of prefs they depend on, there's no real avenue to doing this as they currently stand.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.08