Bug 35495 - Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab
Summary: Cancelling a hold on the OPAC takes the user to their account page, but does ...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35488
Blocks:
  Show dependency tree / graph
 
Reported: 2023-12-05 17:46 UTC by Lucas Gass (lukeg)
Modified: 2024-01-04 18:50 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Circulation function:

Attachments
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold (1.04 KB, patch)
2023-12-05 17:49 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold (1.09 KB, patch)
2023-12-05 23:34 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold (1.15 KB, patch)
2023-12-13 15:09 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-12-05 17:46:39 UTC 
To recreate:
1 - Go to the opac-user.pl page for a user with some holds and cancel a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
Comment 1 Lucas Gass (lukeg) 2023-12-05 17:49:14 UTC 
Created attachment 159603 [details] [review]
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold

To test:
1 - Go to the opac-user.pl page for a user with some holds and cancel a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after cancelling a hold, the refreshed page should have an active hold tab.
Comment 2 David Nind 2023-12-05 23:34:37 UTC 
Created attachment 159609 [details] [review]
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold

To test:
1 - Go to the opac-user.pl page for a user with some holds and cancel a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after cancelling a hold, the refreshed page should have an active hold tab.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-13 15:09:13 UTC 
Created attachment 159806 [details] [review]
Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold

To test:
1 - Go to the opac-user.pl page for a user with some holds and cancel a hold.
2 - Note after placing the hold the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds
3 - Note the holds tab is not active
4. APPLY PATCH and restart all
5. Now after cancelling a hold, the refreshed page should have an active hold tab.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-13 15:09:28 UTC 
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-14 15:31:50 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 14:10:00 UTC 
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass (lukeg) 2024-01-04 18:50:30 UTC 
Backported to 23.05.x for upcoming 23.05.08