Bug 35496 - Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab
Summary: Placing an article request on the OPAC takes the user to their account page, ...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on: 35488
Blocks:
  Show dependency tree / graph
 
Reported: 2023-12-05 17:54 UTC by Lucas Gass (lukeg)
Modified: 2024-01-04 18:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08
Circulation function:

Attachments
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request (2.72 KB, patch)
2023-12-05 18:07 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request (2.76 KB, patch)
2023-12-05 23:40 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request (2.82 KB, patch)
2023-12-13 15:40 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Bug 35496: (QA follow-up): tidy up code (1.95 KB, patch)
2023-12-13 15:40 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-12-05 17:54:54 UTC 
To recreate:
1 - Turn on ArticleRequests 
1 - Place an  Article Requests on the opac
2 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
3 - Note the article request tab is not active
Comment 1 Lucas Gass (lukeg) 2023-12-05 18:07:04 UTC 
Created attachment 159605 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.
Comment 2 David Nind 2023-12-05 23:40:20 UTC 
Created attachment 159610 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-13 15:40:24 UTC 
Created attachment 159808 [details] [review]
Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request

To test:
1 - Turn on ArticleRequests
2 - Place an  Article Requests on the opac
3 - Note after placing the request the URL is:
    http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests
4 - Note the article request tab is not active
5 - APPLY PATCH and restart_all
6. Try steps 2 - 4 again, this time the article request tab should be open by default.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-13 15:40:26 UTC 
Created attachment 159809 [details] [review]
Bug 35496: (QA follow-up): tidy up code
Comment 5 Victor Grousset/tuxayo 2023-12-13 15:45:03 UTC 
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 6 Katrin Fischer 2023-12-14 15:31:53 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 14:11:04 UTC 
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass (lukeg) 2024-01-04 18:51:50 UTC 
Backported to 23.05.x for upcoming 23.05.08