The CollapseFieldsPatronAddForm system preference controls whether sections of the patron add/edit form are collapsed by default. Since Bug 25654 we have an additional section for Non-patron guarantor. This should be added to the list of CollapseFieldsPatronAddForm options.
Created attachment 159627 [details] [review] Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear.
For me, this worked except for under the "Add patron (Kid) heading: it only shows [] Show collapsed fields (without No-patron guarantor). For example, if I ticked Non-patron guarantor and Patron guarantor, this shows under the heading: [] Show collapsed fields: Guarantor information | (As an aside, I don't think the display under the heading is that great, but I have no suggestions...)
Created attachment 160034 [details] [review] Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear.
Created attachment 160086 [details] [review] Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 161028 [details] [review] Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.09.