Bug 35510 - Non-patron guarantor missing from CollapseFieldsPatronAddForm options
Summary: Non-patron guarantor missing from CollapseFieldsPatronAddForm options
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 25654
Blocks: 35511
  Show dependency treegraph
 
Reported: 2023-12-06 17:17 UTC by Owen Leonard
Modified: 2024-02-02 17:53 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This adds Non-patron guarantor as an option to the CollapseFieldsPatronAddForm system preference - this section can now be collapsed on the patron form.
Version(s) released in:
24.05.00,23.11.02,23.05.09


Attachments
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options (2.87 KB, patch)
2023-12-06 17:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options (3.55 KB, patch)
2023-12-19 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options (3.59 KB, patch)
2023-12-19 22:27 UTC, David Nind
Details | Diff | Splinter Review
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options (3.65 KB, patch)
2024-01-14 19:13 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-12-06 17:17:57 UTC
The CollapseFieldsPatronAddForm system preference controls whether sections of the patron add/edit form are collapsed by default. Since Bug 25654 we have an additional section for Non-patron guarantor. This should be added to the list of CollapseFieldsPatronAddForm options.
Comment 1 Owen Leonard 2023-12-06 17:49:56 UTC
Created attachment 159627 [details] [review]
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options

This patch adds a missing option to the CollapseFieldsPatronAddForm
system preference so that the "Non-patron guarantor" section can be
collapsed by default.

To test, apply the patch and go to Administration -> System preferences.

- Search for CollapseFieldsPatronAddForm.
- In the dropdown of options you should see an entry for "Non-patron
  guarantor."
- Click "Select all" and save your changes.
- Go to Patrons -> New patron and choose a patron category which can
  have a guarantor (for example J - Juvenile)
- The patron entry page should load with all sections collapsed,
  including the Non-patron guarantor section.
- Uncheck  all options in the CollapseFieldsPatronAddForm
  preference and return to the patron entry form. All sections should
  now appear.
Comment 2 David Nind 2023-12-06 20:58:31 UTC
For me, this worked except for under the "Add patron (Kid) heading: it only shows [] Show collapsed fields (without No-patron guarantor).

For example, if I ticked Non-patron guarantor and Patron guarantor, this shows under the heading:

[] Show collapsed fields: Guarantor information | 

(As an aside, I don't think the display under the heading is that great, but I have no suggestions...)
Comment 3 Owen Leonard 2023-12-19 16:22:21 UTC
Created attachment 160034 [details] [review]
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options

This patch adds a missing option to the CollapseFieldsPatronAddForm
system preference so that the "Non-patron guarantor" section can be
collapsed by default.

To test, apply the patch and go to Administration -> System preferences.

- Search for CollapseFieldsPatronAddForm.
- In the dropdown of options you should see an entry for "Non-patron
  guarantor."
- Click "Select all" and save your changes.
- Go to Patrons -> New patron and choose a patron category which can
  have a guarantor (for example J - Juvenile)
- The patron entry page should load with all sections collapsed,
  including the Non-patron guarantor section.
- Uncheck  all options in the CollapseFieldsPatronAddForm
  preference and return to the patron entry form. All sections should
  now appear.
Comment 4 David Nind 2023-12-19 22:27:59 UTC
Created attachment 160086 [details] [review]
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options

This patch adds a missing option to the CollapseFieldsPatronAddForm
system preference so that the "Non-patron guarantor" section can be
collapsed by default.

To test, apply the patch and go to Administration -> System preferences.

- Search for CollapseFieldsPatronAddForm.
- In the dropdown of options you should see an entry for "Non-patron
  guarantor."
- Click "Select all" and save your changes.
- Go to Patrons -> New patron and choose a patron category which can
  have a guarantor (for example J - Juvenile)
- The patron entry page should load with all sections collapsed,
  including the Non-patron guarantor section.
- Uncheck  all options in the CollapseFieldsPatronAddForm
  preference and return to the patron entry form. All sections should
  now appear.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Victor Grousset/tuxayo 2024-01-14 19:13:40 UTC
Created attachment 161028 [details] [review]
Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options

This patch adds a missing option to the CollapseFieldsPatronAddForm
system preference so that the "Non-patron guarantor" section can be
collapsed by default.

To test, apply the patch and go to Administration -> System preferences.

- Search for CollapseFieldsPatronAddForm.
- In the dropdown of options you should see an entry for "Non-patron
  guarantor."
- Click "Select all" and save your changes.
- Go to Patrons -> New patron and choose a patron category which can
  have a guarantor (for example J - Juvenile)
- The patron entry page should load with all sections collapsed,
  including the Non-patron guarantor section.
- Uncheck  all options in the CollapseFieldsPatronAddForm
  preference and return to the patron entry form. All sections should
  now appear.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-01-14 19:15:15 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Katrin Fischer 2024-01-16 11:09:29 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2024-01-17 09:46:56 UTC
Pushed to 23.11.x for 23.11.02
Comment 9 Lucas Gass 2024-02-02 17:53:39 UTC
Backported to 23.05.x for upcoming 23.05.09.