35528 – Avoid 'click' for links in system preferences

Bug 35528 - Avoid 'click' for links in system preferences

Summary: Avoid 'click' for links in system preferences

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Katrin Fischer
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:	35527
	Show dependency tree / graph

Reported:	2023-12-10 14:56 UTC by Katrin Fischer
Modified:	2024-12-23 08:05 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.05.00,23.11.02
Circulation function:

Attachments
Bug 35528: Remove 'click' from links in system preferences (6.10 KB, patch) 2023-12-10 15:05 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 35528: Remove 'click' from links in system preferences (6.15 KB, patch) 2023-12-11 09:51 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 35528: Remove 'click' from links in system preferences (6.21 KB, patch) 2023-12-18 11:51 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Katrin Fischer 2023-12-10 14:56:28 UTC

Comment 1 Katrin Fischer 2023-12-10 15:05:53 UTC

Created attachment 159699 [details] [review]
Bug 35528: Remove 'click' from links in system preferences

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

This updates the occurences in the sytem preferences editor.

To test:
* Go to system preferences like OpacUserCSS that allow editing
  in a textarea
* Verify link descrptions for editing and collapsing the area
* For a section of grouped system preferences, hover over the
  arrow and verify the text for collapsing/uncollapsing the area
* Apply patch, restart all
* Verify the links and tool tips have been updated

Comment 2 David Nind 2023-12-11 09:51:00 UTC

Created attachment 159708 [details] [review]
Bug 35528: Remove 'click' from links in system preferences

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

This updates the occurences in the sytem preferences editor.

To test:
* Go to system preferences like OpacUserCSS that allow editing
  in a textarea
* Verify link descrptions for editing and collapsing the area
* For a section of grouped system preferences, hover over the
  arrow and verify the text for collapsing/uncollapsing the area
* Apply patch, restart all
* Verify the links and tool tips have been updated

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Tomás Cohen Arazi (tcohen) 2023-12-18 11:51:59 UTC

Created attachment 159954 [details] [review]
Bug 35528: Remove 'click' from links in system preferences

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

This updates the occurences in the sytem preferences editor.

To test:
* Go to system preferences like OpacUserCSS that allow editing
  in a textarea
* Verify link descrptions for editing and collapsing the area
* For a section of grouped system preferences, hover over the
  arrow and verify the text for collapsing/uncollapsing the area
* Apply patch, restart all
* Verify the links and tool tips have been updated

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 4 Katrin Fischer 2023-12-18 14:25:50 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 5 Fridolin Somers 2024-01-03 14:25:28 UTC

Pushed to 23.11.x for 23.11.02

Comment 6 Lucas Gass (lukeg) 2024-01-04 20:18:22 UTC

Doesn't apply cleanly to 23.05.x, no backport.