Bug 35529 - Avoid 'click' for links in library administration
Summary: Avoid 'click' for links in library administration
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Julian Maurice
URL:
Keywords:
Depends on:
Blocks: 35527
  Show dependency tree / graph
 
Reported: 2023-12-10 15:08 UTC by Katrin Fischer
Modified: 2024-12-23 08:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:

Attachments
Bug 35529: Avoid 'click' in link in library administration (3.00 KB, patch)
2023-12-10 15:19 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 35529: Avoid 'click' in link in library administration (3.05 KB, patch)
2023-12-11 09:54 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35529: Avoid 'click' in link in library administration (3.11 KB, patch)
2023-12-21 10:51 UTC, Julian Maurice 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-10 15:08:43 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Katrin Fischer

        

        
        

        
          2023-12-10 15:19:00 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 2
        

        
          David Nind

        

        
        

        
          2023-12-11 09:54:21 UTC
        

      






Created attachment 159709 [details] [review]
Bug 35529: Avoid 'click' in link in library administration

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

To test:
* Go to administration > libraries
* Edit any library
* Verify link texts for UserCSS and UserJS
  * Click to edit
  * Click to collapse
* Apply patch, restart all
* Verify links have been updated, click removed

Signed-off-by: David Nind <david@davidnind.com>

    


    


      



        
          Comment 3
        

        
          Julian Maurice

        

        
        

        
          2023-12-21 10:51:14 UTC
        

      






Created attachment 160190 [details] [review]
Bug 35529: Avoid 'click' in link in library administration

It's not necessary to label a link with 'click', it being
a link and being formatted as such is enough.

To test:
* Go to administration > libraries
* Edit any library
* Verify link texts for UserCSS and UserJS
  * Click to edit
  * Click to collapse
* Apply patch, restart all
* Verify links have been updated, click removed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

    


    


      



        
          Comment 4
        

        
          Katrin Fischer

        

        
        

        
          2023-12-27 18:10:18 UTC
        

      






Pushed for 24.05!

Well done everyone, thank you!

    


    


      



        
          Comment 5
        

        
          Fridolin Somers

        

        
        

        
          2024-01-03 15:34:30 UTC
        

      






Pushed to 23.11.x for 23.11.02

    


    


      



        
          Comment 6
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-01-04 21:02:23 UTC
        

      






Doesn't apply clean to 23.05.x, no backport.