It looks like they are for OPAC, but it's not visible in the library edit form. We should add a hint or rename the options with prefix OPAC.
Created attachment 160626 [details] [review] Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels
Created attachment 160666 [details] [review] Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind <david@davidnind.com>
I don't mind the replacement labels, as they are a great improvement: - UserJS -> Specific OPAC JS - UserCSS -> Specific OPAC CSS Some alternatives: 1. Library specific OPAC JavaScript Library specific OPAC CSS 2. Library specific JavaScript for the OPAC Library specific CSS for the OPAC 3. OPAC JavaScript for this library OPAC CSS for this library I think I like 3 better, but leaving up to the QA Team.
As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter.
(In reply to Katrin Fischer from comment #4) > As we are on the library page, I feel like we don't need to point out that > it's library specific, all the fields on the page are and it would help to > keep the label/hint a bit shorter. I agree.
Created attachment 161423 [details] [review] Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC In libraries administration new fields UserCSS and UserJS are for OPAC, this should be in label. This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help : Library specific CSS can be defined in ... Test plan 1) Go to Administration > Libraries 2) Modify a library 3) Check you see new labels Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Changed status to "Needs documenting" - this changes the field label, which is described in the library administration section[1] and needs updating. [1] https://koha-community.org/manual/latest/en/html/administration.html#libraries