Bug 35538 - List of libraries on OPAC self registration form should sort by branchname rather than branchcode
Summary: List of libraries on OPAC self registration form should sort by branchname ra...
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-11 12:29 UTC by Lucy Vaux-Harvey
Modified: 2024-02-07 17:20 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35538: Sort OPAC self registration library list by library name (1.48 KB, patch)
2023-12-18 19:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35538: Sort OPAC self registration library list by library name (1.53 KB, patch)
2023-12-18 21:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 35538: Sort OPAC self registration library list by library name (1.60 KB, patch)
2024-02-07 17:19 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucy Vaux-Harvey 2023-12-11 12:29:20 UTC
The dropdown list of libraries on the OPAC self registration form is ordered by branchcode.  It would be great if this list was ordered by branchname as it is for the Libraries search filter.
Comment 1 Owen Leonard 2023-12-18 19:13:30 UTC
Created attachment 159979 [details] [review]
Bug 35538: Sort OPAC self registration library list by library name

This patch modifies opac-memberentry.pl so that the list of libraries is
sorted by library name instead of library code.

To test, apply the patch and restart services.

- If using the default testing data you'll have to go to Administration
  -> Libraries and edit one or more libraries so that the library name
  is alphabetically different than the library code. e.g. Centerville ->
  Zanzibar.
- Go the OPAC and click "Create an account" (requires the
  PatronSelfRegistration system preference).
- Under "Home library," the dropdown of libraries should be ordered by
  library name.
Comment 2 David Nind 2023-12-18 21:25:01 UTC
Created attachment 159986 [details] [review]
Bug 35538: Sort OPAC self registration library list by library name

This patch modifies opac-memberentry.pl so that the list of libraries is
sorted by library name instead of library code.

To test, apply the patch and restart services.

- If using the default testing data you'll have to go to Administration
  -> Libraries and edit one or more libraries so that the library name
  is alphabetically different than the library code. e.g. Centerville ->
  Zanzibar.
- Go the OPAC and click "Create an account" (requires the
  PatronSelfRegistration system preference).
- Under "Home library," the dropdown of libraries should be ordered by
  library name.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa 2024-02-07 17:19:08 UTC
Created attachment 161833 [details] [review]
Bug 35538: Sort OPAC self registration library list by library name

This patch modifies opac-memberentry.pl so that the list of libraries is
sorted by library name instead of library code.

To test, apply the patch and restart services.

- If using the default testing data you'll have to go to Administration
  -> Libraries and edit one or more libraries so that the library name
  is alphabetically different than the library code. e.g. Centerville ->
  Zanzibar.
- Go the OPAC and click "Create an account" (requires the
  PatronSelfRegistration system preference).
- Under "Home library," the dropdown of libraries should be ordered by
  library name.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2024-02-07 17:20:25 UTC
Looks good and QA script is happy. Passing QA