Bug 35596 - Error in writeoff_debts documentation
Summary: Error in writeoff_debts documentation
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Bugs List
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 27049
Blocks:
  Show dependency tree / graph
 
Reported: 2023-12-18 21:04 UTC by Caroline Cyr La Rose
Modified: 2024-02-14 15:17 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09
Circulation function:

Attachments
Bug 35596: Error in writeoff_debts documentation (1.06 KB, patch)
2023-12-18 21:08 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Bug 35596: Error in writeoff_debts documentation (1.11 KB, patch)
2023-12-18 21:19 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35596: Error in writeoff_debts documentation (1.20 KB, patch)
2024-01-26 10:51 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-12-18 21:04:17 UTC 
Inside the writeoff_debts.pl script it says

=item B<--type>

Writeoff debts of the passed type. Accepts a list of CREDIT_TYPE_CODEs.

But I think what is meant here is debit type code, not credit types.
Comment 1 Caroline Cyr La Rose 2023-12-18 21:08:39 UTC 
Created attachment 159984 [details] [review]
Bug 35596: Error in writeoff_debts documentation

This patch corrects an error in the documentation of the
writeoff_debts.pl script. The --type parameter accepts debit type codes,
not credit type codes.

To test:
-  Run ./misc/cronjobs/writeoff_debts.pl
-  Make sure the sentence for --type makes sense, grammar and spelling
   are correct
Comment 2 David Nind 2023-12-18 21:19:41 UTC 
Created attachment 159985 [details] [review]
Bug 35596: Error in writeoff_debts documentation

This patch corrects an error in the documentation of the
writeoff_debts.pl script. The --type parameter accepts debit type codes,
not credit type codes.

To test:
-  Run ./misc/cronjobs/writeoff_debts.pl
-  Make sure the sentence for --type makes sense, grammar and spelling
   are correct

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-01-26 10:51:44 UTC 
Created attachment 161505 [details] [review]
Bug 35596: Error in writeoff_debts documentation

This patch corrects an error in the documentation of the
writeoff_debts.pl script. The --type parameter accepts debit type codes,
not credit type codes.

To test:
-  Run ./misc/cronjobs/writeoff_debts.pl
-  Make sure the sentence for --type makes sense, grammar and spelling
   are correct

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-01-29 11:28:59 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-02-01 13:48:31 UTC 
Pushed to 23.11.x for 23.11.03
Comment 6 Lucas Gass (lukeg) 2024-02-14 15:17:11 UTC 
Backported to 23.05.x for upcoming 23.05.09