The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set. We should rethink the logic...
Created attachment 159994 [details] [review] Bug 35600: Prevent checkouts table to flicker The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set. This patch makes the table hidden by default, and show it if/when needed Test plan: Check an item out, see the checkouts list view Play with "Always show checkouts automatically", refresh the page => UI should behave better than before this patch
We might want to test if LoadCheckoutsTableDelay system preference also still works as expected.
(In reply to Katrin Fischer from comment #2) > We might want to test if LoadCheckoutsTableDelay system preference also > still works as expected. It does still work.
Created attachment 160023 [details] [review] Bug 35600: Prevent checkouts table to flicker The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set. This patch makes the table hidden by default, and show it if/when needed Test plan: Check an item out, see the checkouts list view Play with "Always show checkouts automatically", refresh the page => UI should behave better than before this patch Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 160085 [details] [review] Bug 35600: Prevent checkouts table to flicker The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set. This patch makes the table hidden by default, and show it if/when needed Test plan: Check an item out, see the checkouts list view Play with "Always show checkouts automatically", refresh the page => UI should behave better than before this patch Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
That flickering was bad thanks for the simple fix :D Works, makes sense, QA script happy, code looks good, passing QA :)
Created attachment 160102 [details] [review] Bug 35600: Prevent checkouts table to flicker The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set. This patch makes the table hidden by default, and show it if/when needed Test plan: Check an item out, see the checkouts list view Play with "Always show checkouts automatically", refresh the page => UI should behave better than before this patch Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This is much cleaner, no regressions found. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.08