Bug 35602 - Typo: AutoMemberNum
Summary: Typo: AutoMemberNum
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-12-19 13:06 UTC by Magnus Enger
Modified: 2024-01-15 14:11 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35602: Fix typo AutoMemberNum (1.78 KB, patch)
2024-01-06 19:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35602: Fix typo AutoMemberNum (1.83 KB, patch)
2024-01-07 14:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 35602: Fix typo AutoMemberNum (1.90 KB, patch)
2024-01-11 08:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2023-12-19 13:06:56 UTC
$ grep -rn AutoMemberNum *
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:925:                                                        <br/><span class="error">AutoMemberNum is set to enabled, but card number is marked as mandatory in BorrowerMandatoryField: auto calc has been disabled.</span>

It should be autoMemberNum, not AutoMemberNum. 

It has very limited consequences, but consistency is good, right?
Comment 1 Katrin Fischer 2024-01-06 19:43:35 UTC
Created attachment 160601 [details] [review]
Bug 35602: Fix typo AutoMemberNum

The correct spelling is autoMemberNum.

To test:
* Enable autoMemberNum system preference
* Set cardnumber to mandatory in BorrowerMandatoryField
* Add a new patron account
* Verify correct spelling in hint below cardnumber input field
Comment 2 David Nind 2024-01-07 14:44:09 UTC
Created attachment 160609 [details] [review]
Bug 35602: Fix typo AutoMemberNum

The correct spelling is autoMemberNum.

To test:
* Enable autoMemberNum system preference
* Set cardnumber to mandatory in BorrowerMandatoryField
* Add a new patron account
* Verify correct spelling in hint below cardnumber input field

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2024-01-11 08:33:47 UTC
Created attachment 160814 [details] [review]
Bug 35602: Fix typo AutoMemberNum

The correct spelling is autoMemberNum.

To test:
* Enable autoMemberNum system preference
* Set cardnumber to mandatory in BorrowerMandatoryField
* Add a new patron account
* Verify correct spelling in hint below cardnumber input field

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2024-01-11 14:50:09 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-15 14:11:03 UTC
Pushed to 23.11.x for 23.11.02