Bug 35707 - Item statuses in the holdings table on biblio details should appear one per line
Summary: Item statuses in the holdings table on biblio details should appear one per line
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-05 12:08 UTC by Martin Renvoize
Modified: 2024-01-17 10:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the display of item status column in the staff interface holdings table for a record. If there is more than one status to display, they are now displayed on separate lines, instead of running together as one continuous line.
Version(s) released in:
24.05.00


Attachments
Current display (14.22 KB, image/png)
2024-01-05 12:09 UTC, Martin Renvoize
Details
Proposed change (18.47 KB, image/png)
2024-01-05 12:09 UTC, Martin Renvoize
Details
Bug 35707: Add clearfix to item statuses (9.55 KB, patch)
2024-01-05 12:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35707: (alternate) Add clearfix to item statuses (10.81 KB, patch)
2024-01-08 16:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35707: (alternate) Add clearfix to item statuses (10.86 KB, patch)
2024-01-08 21:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 35707: (alternate) Add clearfix to item statuses (10.93 KB, patch)
2024-01-09 09:23 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2024-01-05 12:08:31 UTC
The item status field may contain more than one status message, but currently, those messages are one after the other as opposed to one above the other.

It would be clearer to display them one above the other.
Comment 1 Martin Renvoize 2024-01-05 12:09:18 UTC
Created attachment 160569 [details]
Current display
Comment 2 Martin Renvoize 2024-01-05 12:09:59 UTC
Created attachment 160570 [details]
Proposed change
Comment 3 Martin Renvoize 2024-01-05 12:16:36 UTC
Created attachment 160571 [details] [review]
Bug 35707: Add clearfix to item statuses

This patch adds the clearfix class to each of item status/availabiliy
spans.  This has the effect of pushing each status onto it's own line.

Test plan
1) Add an item to stockrotation and trigger the first transfer
2) Place a hold on the item
3) Note that you will now see two status's, one above the other as
   displayed in the screenshots attached to the bug.
Comment 4 David Nind 2024-01-05 20:09:01 UTC
Sometimes things move too quickly 8-(..

 git bz apply 35707

Bug 35707 - Item statuses in the holdings table on biblio details should appear one per line

160571 - Bug 35707: Add clearfix to item statuses

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35707: Add clearfix to item statuses
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 35707: Add clearfix to item statuses
Comment 5 Owen Leonard 2024-01-08 16:56:50 UTC
Created attachment 160651 [details] [review]
Bug 35707: (alternate) Add clearfix to item statuses

This proposed alterantive patch adds changes the status <span>s to
<div>s. A div is basically the block-level equivalent of a span. This
has the same effect of pushing each status onto its own line.

The patch also adds generic "item_status" class to the <div>s as well so
that we can attach a consistent style to all statuses. The patch
includes a small amount of padding on these items in order to repeat
legibility.

To test, apply the patch and rebuild the staff interface CSS.

1) Add an item to stockrotation and trigger the first transfer
2) Place a hold on the item
3) Note that you will now see two statuses, one above the other as
   displayed in the screenshots attached to the bug.
Comment 6 David Nind 2024-01-08 21:38:51 UTC
Created attachment 160663 [details] [review]
Bug 35707: (alternate) Add clearfix to item statuses

This proposed alterantive patch adds changes the status <span>s to
<div>s. A div is basically the block-level equivalent of a span. This
has the same effect of pushing each status onto its own line.

The patch also adds generic "item_status" class to the <div>s as well so
that we can attach a consistent style to all statuses. The patch
includes a small amount of padding on these items in order to repeat
legibility.

To test, apply the patch and rebuild the staff interface CSS.

1) Add an item to stockrotation and trigger the first transfer
2) Place a hold on the item
3) Note that you will now see two statuses, one above the other as
   displayed in the screenshots attached to the bug.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Martin Renvoize 2024-01-09 09:23:14 UTC
Created attachment 160683 [details] [review]
Bug 35707: (alternate) Add clearfix to item statuses

This proposed alterantive patch adds changes the status <span>s to
<div>s. A div is basically the block-level equivalent of a span. This
has the same effect of pushing each status onto its own line.

The patch also adds generic "item_status" class to the <div>s as well so
that we can attach a consistent style to all statuses. The patch
includes a small amount of padding on these items in order to repeat
legibility.

To test, apply the patch and rebuild the staff interface CSS.

1) Add an item to stockrotation and trigger the first transfer
2) Place a hold on the item
3) Note that you will now see two statuses, one above the other as
   displayed in the screenshots attached to the bug.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2024-01-09 09:24:15 UTC
As Owen re-wrote this, and I agree, 'div' is more appropriate really.

I'm using the opportunity to QA.

Passing QA :)
Comment 9 Katrin Fischer 2024-01-16 15:36:15 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 10 Fridolin Somers 2024-01-17 10:00:42 UTC
Since this is an important information for librarians and it may have customized via CSS, I prefer not to push to stable 23.11.