The item status field may contain more than one status message, but currently, those messages are one after the other as opposed to one above the other. It would be clearer to display them one above the other.
Created attachment 160569 [details] Current display
Created attachment 160570 [details] Proposed change
Created attachment 160571 [details] [review] Bug 35707: Add clearfix to item statuses This patch adds the clearfix class to each of item status/availabiliy spans. This has the effect of pushing each status onto it's own line. Test plan 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two status's, one above the other as displayed in the screenshots attached to the bug.
Sometimes things move too quickly 8-(.. git bz apply 35707 Bug 35707 - Item statuses in the holdings table on biblio details should appear one per line 160571 - Bug 35707: Add clearfix to item statuses Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35707: Add clearfix to item statuses Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35707: Add clearfix to item statuses
Created attachment 160651 [details] [review] Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status <span>s to <div>s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the <div>s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug.
Created attachment 160663 [details] [review] Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status <span>s to <div>s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the <div>s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160683 [details] [review] Bug 35707: (alternate) Add clearfix to item statuses This proposed alterantive patch adds changes the status <span>s to <div>s. A div is basically the block-level equivalent of a span. This has the same effect of pushing each status onto its own line. The patch also adds generic "item_status" class to the <div>s as well so that we can attach a consistent style to all statuses. The patch includes a small amount of padding on these items in order to repeat legibility. To test, apply the patch and rebuild the staff interface CSS. 1) Add an item to stockrotation and trigger the first transfer 2) Place a hold on the item 3) Note that you will now see two statuses, one above the other as displayed in the screenshots attached to the bug. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
As Owen re-wrote this, and I agree, 'div' is more appropriate really. I'm using the opportunity to QA. Passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Since this is an important information for librarians and it may have customized via CSS, I prefer not to push to stable 23.11.