Bug 35721 - Replace ModItemTransfer calls in circ/returns.pl
Summary: Replace ModItemTransfer calls in circ/returns.pl
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 35100
Blocks: 25754 28294
  Show dependency treegraph
 
Reported: 2024-01-08 09:48 UTC by Martin Renvoize
Modified: 2024-04-24 15:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (1.66 KB, patch)
2024-01-08 12:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (2.23 KB, patch)
2024-01-08 14:48 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (2.32 KB, patch)
2024-01-08 14:56 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (2.32 KB, patch)
2024-01-08 16:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (2.37 KB, patch)
2024-01-08 22:02 UTC, David Nind
Details | Diff | Splinter Review
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl (2.37 KB, patch)
2024-01-09 13:16 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2024-01-08 09:48:36 UTC
ModItemTransfer is slowly getting removed and replaced by calls to the relevant Koha::Item and Koha::Item::Transfer methods.
Comment 1 Martin Renvoize 2024-01-08 12:56:51 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2024-01-08 14:48:41 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2024-01-08 14:56:51 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2024-01-08 16:33:38 UTC Comment hidden (obsolete)
Comment 5 David Nind 2024-01-08 22:02:03 UTC
Created attachment 160665 [details] [review]
Bug 35721: ModItemTransfer -> Koha::Item->request_transfer - returns.pl

This patch replaces the call to ModItemTransfer in circ/returns.pl with
a call to Koha::Item->request_transfer and
Koha::Item::Transfer->transit.

Test plan
1) Set 'AutomaticItemReturn' to "Don't"
2) Check an item in at a location other than it's 'home' or 'holding'
   branch
3) Note you should be asked a about returning the item to another branch
4) Opting to not proceed should NOT result in a row in the
   branchtransfers table
5) Option to proceed (either with a print slip or just 'OK') should
   result in a branchtransfer from the current checkin branch to the
home or holding branch depending on the circulation rules.
5a) The item should be marked as immediately in transit in, i.e. the
   'datesent' set to today.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Martin Renvoize 2024-01-09 13:16:09 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2024-04-18 12:17:00 UTC
Dep does not apply.