Bug 35807 - Update catalog statistics report
Summary: Update catalog statistics report
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 35809
  Show dependency treegraph
 
Reported: 2024-01-13 22:10 UTC by Katrin Fischer
Modified: 2024-03-22 22:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35807: Reindent catalogue_stats.tt (33.59 KB, patch)
2024-01-14 11:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35807: Update catalog statistics search form and result list (8.15 KB, patch)
2024-01-14 11:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35807: Improve display of appliced filters and results contents (14.78 KB, patch)
2024-01-14 11:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-01-13 22:10:22 UTC
The catalog statistics report has several known issues regarding translatability.
Comment 1 Katrin Fischer 2024-01-14 11:29:29 UTC
Created attachment 161024 [details] [review]
Bug 35807: Reindent catalogue_stats.tt

This patch only contains whitespace changes, including
switching from tabs to 4 spaces for indenting
consistently.

To test:
* There should be no change in appearance and behavior
Comment 2 Katrin Fischer 2024-01-14 11:29:31 UTC
Created attachment 161025 [details] [review]
Bug 35807: Update catalog statistics search form and result list

This makes some small changes to the form to be
more consistent with other parts of Koha:

Search form
* Koha full call number => Item call number
* Filter barcode => Barcode

Result list
* The result table had a white background with a shadow.
  It was changed to the nromal "page-section" white
  background without a shadow/3D effect.

To test:
* Verify current layout as described above
* Apply patch and run yarn build to update CSS
* Verify changes
Comment 3 Katrin Fischer 2024-01-14 11:29:34 UTC
Created attachment 161026 [details] [review]
Bug 35807: Improve display of appliced filters and results contents

This makes various improvements to the display of the results:

* Filters now display as a list.
* If codes can be resolved into a description, this is done
  in the filters and results table for:
  * Home library
  * Item types (for both setting of item_level_ityes)
  * Collection
  * Shelving location
  * Not for loan status
* The first cell displays a nice description for row/column
  filters that have been selected (X / Y)
* Date formatting is used and date columns sort correctly
  for different DateFormat settings

To test:
* Verify above changes by testing several combinations of
  row / column combinations and filters

Note: The "Count deleted items" option changes the search form
      and the data. Everything should still displa nicely if
      this is used.

Note: Removes unused class 'hilighted' used for marking even/uneven
      cells in the past.
Comment 4 David Nind 2024-03-22 22:41:34 UTC
The patches no longer apply 8-(...

git bz apply 35807

Bug 35807 - Update catalog statistics report

161024 - Bug 35807: Reindent catalogue_stats.tt
161025 - Bug 35807: Update catalog statistics search form and result list
161026 - Bug 35807: Improve display of appliced filters and results contents

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35807: Reindent catalogue_stats.tt
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 35807: Reindent catalogue_stats.tt