Bug 3586 - errors pages are sent with HTTP 200 OK header
Summary: errors pages are sent with HTTP 200 OK header
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Browser compatibility (show other bugs)
Version: rel_3_0
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Henri-Damien LAURENT
QA Contact:
URL: http://koha/cgi-bin/koha/errors/404.pl
Keywords: browser_compatibility
Depends on:
Blocks:
 
Reported: 2009-09-07 02:38 UTC by Chris Cormack
Modified: 2012-10-25 22:52 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:12:34 UTC


---- Reported by mjr@ttllp.co.uk 2009-09-07 14:38:23 ----

All of the errors scripts send results back to clients with HTTP 200 OK header.  This leads to some clients taking incorrect actions.

To see the fault, try

curl -I http://koha/cgi-bin/koha/errors/404.pl 

and look at the first line of output.

Looks to me like C4::Output::output_html_with_http_headers doesn't pass status code to C4::Output::output_with_http_headers and the errors scripts don't send error codes anyway.



---- Additional Comments From mjr@ttllp.co.uk 2009-11-02 15:10:45 ----

http://lists.koha.org/pipermail/koha-patches/2009-November/004785.html




---- Additional Comments From gmcharlt@gmail.com 2010-02-15 01:07:29 ----

Pushed Sebastien Hinderer's patch as de94e449cdb7bb3f92534fa455feb6ddc480e17b.  Please test and close.



---- Additional Comments From mjr@ttllp.co.uk 2010-02-15 10:59:28 ----

Looks good to me.  Retagging to rel_3_0, pull request just emailed.




---- Additional Comments From henridamien@koha-fr.org 2010-02-15 14:59:05 ----

patch pushed to 3.0.x



---- Additional Comments From mjr@ttllp.co.uk 2010-02-15 15:27:30 ----

Thank you. Resolving.  Will close once tested on live site.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:12 UTC  ---

This bug was previously known as _bug_ 3586 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3586

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was mjr@ttllp.co.uk.