Bug 31422 implemented a warning sign, when a patron has a patron category that you are not allowed to set due to library limitations on the code. It should appear right next to the field, but might appear on the other side of the page now being easily missed. To test: * User's login branch and home library is: Centerville * Patron category "B - Board" is limited to Franklin * Create a new patron: Board doesn't show * Edit an existing patron with another patron category: Board doesn't show * Edit a patron with Board category from Centerville: Board appears in the list of options but the nice little icon with the tooltip has moved all the way to the right... Maybe another tiny side effect of the staff re-design?
Created attachment 163617 [details] [review] Bug 35868: Warning sign for using a patron category that is limited to another library has moved to other side of page Bug 31422 implemented a warning sign, when a patron has a patron category that you are not allowed to set due to library limitations on the code. It should appear right next to the field, but might appear on the other side of the page now being easily missed. This patch simply removes the float:right CSS rule. To test: * User's login branch and home library is: Centerville * Patron category "B - Board" is limited to Franklin * Create a new patron: Board doesn't show * Edit an existing patron with another patron category: Board doesn't show * Edit a patron with Board category from Centerville => Check the warning icon with the tooltip is close to the category select
Created attachment 163626 [details] [review] Bug 35868: Warning sign for using a patron category that is limited to another library has moved to other side of page Bug 31422 implemented a warning sign, when a patron has a patron category that you are not allowed to set due to library limitations on the code. It should appear right next to the field, but might appear on the other side of the page now being easily missed. This patch simply removes the float:right CSS rule. To test: * User's login branch and home library is: Centerville * Patron category "B - Board" is limited to Franklin * Create a new patron: Board doesn't show * Edit an existing patron with another patron category: Board doesn't show * Edit a patron with Board category from Centerville => Check the warning icon with the tooltip is close to the category select Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 164199 [details] [review] Bug 35868: Warning sign for using a patron category that is limited to another library has moved to other side of page Bug 31422 implemented a warning sign, when a patron has a patron category that you are not allowed to set due to library limitations on the code. It should appear right next to the field, but might appear on the other side of the page now being easily missed. This patch simply removes the float:right CSS rule. To test: * User's login branch and home library is: Centerville * Patron category "B - Board" is limited to Franklin * Create a new patron: Board doesn't show * Edit an existing patron with another patron category: Board doesn't show * Edit a patron with Board category from Centerville => Check the warning icon with the tooltip is close to the category select Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Filed this myself in January - really glad to see a fix!
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12