Bug 35922 - t/db_dependent/www/batch.t is failing
Summary: t/db_dependent/www/batch.t is failing
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on: 34913
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-26 16:18 UTC by Katrin Fischer
Modified: 2024-04-26 20:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.10


Attachments
Bug 35922: Fix www/batch.t (1.91 KB, patch)
2024-01-29 13:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-01-26 16:18:47 UTC
Don't know who to blame right now, so filing separately:

prove t/db_dependent/www/batch.t 
t/db_dependent/www/batch.t .. Warning: <retrieval> element has non-unique value in 'name' key attribute: F at t/db_dependent/www/batch.t line 35.
Warning: <retrieval> element has non-unique value in 'name' key attribute: B at t/db_dependent/www/batch.t line 35.
t/db_dependent/www/batch.t .. 13/24 
#   Failed test 'found book'
#   at t/db_dependent/www/batch.t line 90.
#                   undef
#     doesn't match '(?^u:Data structures)'

#   Failed test 'record marked as staged'
#   at t/db_dependent/www/batch.t line 91.
#          got: undef
#     expected: 'imported'

#   Failed test 'record has no matches'
#   at t/db_dependent/www/batch.t line 92.
#          got: undef
#     expected: 'no_match'
Use of uninitialized value $biblionumber in concatenation (.) or string at t/db_dependent/www/batch.t line 96.

#   Failed test 'bib is imported'
#   at t/db_dependent/www/batch.t line 99.
#     searched: "\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}\x{0a}    \x{0a}\x{0a}\x{0a}\x{0a}\x{0a}    \x{0a}\x{0a}"...
#   can't find: "Details for Data structures"
#         LCSS: "Details"
# LCSS context: "      </ul>\x{0a}    </div>\x{0a}\x{0a}\x{0a}    <div id="cartDetails""
t/db_dependent/www/batch.t .. 21/24 Use of uninitialized value $biblionumber in concatenation (.) or string at t/db_dependent/www/batch.t line 116.

#   Failed test 'record marked as reverted'
#   at t/db_dependent/www/batch.t line 124.
#          got: undef
#     expected: 'reverted'
# Looks like you failed 5 tests of 24.
t/db_dependent/www/batch.t .. Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/24 subtests 

Test Summary Report
-------------------
t/db_dependent/www/batch.t (Wstat: 1280 Tests: 24 Failed: 5)
  Failed tests:  15-17, 19, 24
  Non-zero exit status: 5
Files=1, Tests=24, 26 wallclock secs ( 0.02 usr  0.00 sys +  1.76 cusr  0.13 csys =  1.91 CPU)
Result: FAIL
Comment 1 Tomás Cohen Arazi 2024-01-29 13:07:03 UTC
Created attachment 161594 [details] [review]
Bug 35922: Fix www/batch.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Katrin Fischer 2024-01-29 13:10:33 UTC
Obvious fix, speeding things up a bit ;)
Comment 3 Katrin Fischer 2024-01-29 13:10:47 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 4 Fridolin Somers 2024-02-01 16:17:30 UTC
Pushed to 23.11.x for 23.11.03
Comment 5 Lucas Gass 2024-03-19 19:30:42 UTC
Backported to 23.05.x for upcoming 23.05.10