Bug 35940 - Cypress tests for the Preservation module are failing
Summary: Cypress tests for the Preservation module are failing
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 35477
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-30 13:29 UTC by Jonathan Druart
Modified: 2024-04-26 20:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35940: (bug 35477 follow-up) Fix cypress tests (2.48 KB, patch)
2024-01-30 13:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35940: Close modal before typing (1.06 KB, patch)
2024-01-31 16:38 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-30 13:29:24 UTC
AssertionError: Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it.

We moved from message to alert.
Comment 1 Jonathan Druart 2024-01-30 13:30:56 UTC
Created attachment 161635 [details] [review]
Bug 35940: (bug 35477 follow-up) Fix cypress tests

AssertionError: Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it.

We moved from message to alert.
Comment 2 Matt Blenkinsop 2024-01-31 16:38:02 UTC
Timed out retrying after 10000ms: cy.type() failed because this element:

<input required="" class="vs__search" aria-autocomplete="list" aria-labelledby="vs1__combobox" aria-controls="vs1__listbox" type="search" autocomplete="off" data-v-5540f13a="">

is being covered by another element:

<h1 data-v-018a4733="">2 new i...</h1>

The modal appears to need closing
Comment 3 Matt Blenkinsop 2024-01-31 16:38:25 UTC
Created attachment 161699 [details] [review]
Bug 35940: Close modal before typing

Tests currently fail due to a modal remaining open. This patch closes the modal to make the tests pass
Comment 4 Katrin Fischer 2024-02-01 15:46:23 UTC
After getting past the regressions.t fail, we now see this one on Jenkins. I have tested locally and now pushed the patches in hope to get us to green.
Comment 5 Katrin Fischer 2024-02-02 08:13:54 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-13 10:35:06 UTC
Pushed to 23.11.x for 23.11.03