Bug 36000 - Fix CGI::param called in list context from catalogue/search.pl
Summary: Fix CGI::param called in list context from catalogue/search.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-06 12:32 UTC by Marcel de Rooy
Modified: 2024-12-23 08:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:

Attachments
Bug 36000: Fix CGI::param warning in catalogue search (979 bytes, patch)
2024-02-06 12:34 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-02-06 12:32:28 UTC 
$template->param(
           sort      => $cgi->param('sort_by'),
        );
Comment 1 Marcel de Rooy 2024-02-06 12:34:10 UTC 
Created attachment 161775 [details] [review]
Bug 36000: Fix CGI::param warning in catalogue search

Speaks for itself.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-02-06 12:34:36 UTC 
Taking liberty to pass QA myself. Super trivial
Comment 3 Katrin Fischer 2024-03-07 14:04:17 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 4 Fridolin Somers 2024-03-11 09:30:58 UTC 
Pushed to 23.11.x for 23.11.04
Comment 5 Lucas Gass (lukeg) 2024-03-19 15:15:57 UTC 
Backported to 23.05.x for upcoming 23.05.10