Since 23.11, on the checkouts page both in Staff client and OPAC, when a certain item is not renewable, e.g. because it is on hold or max renewals reached, the text "Scheduled for automatic renewal" still appears which is confusing. E.g. In the OPAC it says "Not renewable (on hold)", but right below it, it still says "This item is scheduled for auto renewal." In the Staff client it shows "On hold" and below that "(Scheduled for automatic renewal)".
I think this was a choice on 25393 - to mark that a checkout had auto-renewals enabled.
(In reply to Mirjam Vantieghem from comment #0) > Since 23.11, on the checkouts page both in Staff client and OPAC, when a > certain item is not renewable, e.g. because it is on hold or max renewals > reached, the text "Scheduled for automatic renewal" still appears which is > confusing. > > E.g. In the OPAC it says "Not renewable (on hold)", but right below it, it > still says "This item is scheduled for auto renewal." In the Staff client it > shows "On hold" and below that "(Scheduled for automatic renewal)". Are you able to provide a detailed test plan to reproduce this? Also current values of "No renewal before", "No automatic renewal before" and "Automatic renewal" in the circulation rules. It may be that there is no bug here, as both messages being shown is an expected use case, I believe. It may be that in the situation you describe, a manual renewal is not possible "right now" (because its on hold) but an automatic renewal **attempt** is still going to happen for that specific checkout when the time for the cron to run comes, hence the message. It may be the case that the hold is cancelled in the meantime, and in such event the automatic renewal would succeed, hopefully. I agree that the text being presented may be confusing, but this was done for transparency reasons, i.e. provide full information of what is going on. The alternative would be to just show "Not renewable (on hold)" and nothing else, but an auto renewal attempt would still take place for that checkout eventually. I'm not saying there is no bug here, but the above is the reasoning behind the implementation decisions.
In a practical scenario, the desirable behavior would be for the message about automatic renewal to be informed by how many renewals are remaining, so that when there are no renewals remaining, the message about scheduled automatic renewal would disappear.
Here's another idea that might be simpler but have the same effect. What if the text "Scheduled for automatic renewal" was changed to something like "Automatic renewal enabled"? Would this still communicate the same information (auto-renew is turned on) without implying that an actual renewal is scheduled and pending? Just changing the text means that the two messages would continue to appear together when no renewals were remaining. If it is still too confusing to see an auto-renew message when no renewals are remaining, then it would be ideal for the visibility of the auto-renew message to reference the renewal status so that it would not appear when an item is not renewable.
I think removing the second line of text "This item is scheduled for automatic renewal" would be less confusing for patrons.