It looks like the datatables upgrade in bug 34913 has broken the css in addorderiso2709.pl. The values are no longer displaying in the form and there is a blue highlighted outline around the form
Test plan: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Now save the sysprefs 4) Navigate to acquisitions and go into a basket 5) Click Add to basket and select “From a new file” 6) Download the file attached to this bug 7) Import the file and when the job is complete click “Add staged files to basket” 8) Click the checkbox next to the record to display the items. All the fields are empty but if you inspect the elements you can see the values attached to the inputs. There is also a blue highlighted outline around the form
Created attachment 161885 [details] Sample file
Created attachment 161931 [details] [review] Bug 36035: Wrong text colour in addorderiso2709.pl This patch updates the "Order staged MARC records" page so that the class which is added upon selection is more unique to avoid a collision with some default DataTables styles. These classes are used in JavaScript selectors, not for visual style. The patch also adds some custom CSS variables to global.scss to override the defaults for the DataTables "selected" style, in case this issue crops up again. To test, apply the patch and rebuild the staff interface CSS. Follow the test plan from the bug report: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l 4) Save the sysprefs 5) Navigate to acquisitions and go into a basket 6) Click "Add to basket" and select "From a new file" 7) Download the file attached to this bug 8) Import the file and when the job is complete click "Add staged files to basket" 9) Click the checkbox next to the record to display the items. - The expanded form should look correct. 10) Add one or more items to the order and confirm that submitting the form works correctly. To test the new default "selected" DataTables style, view a page with a DataTable, e.g. Administration -> Libraries. - Right-click on one of the table rows and choose "Inspect" - Click the table row element, e.g. '<tr class="odd">' - Double-click the class name and replace it with "selected." - The row you inspected should now have a pale green background and text colors should remain the same.
Created attachment 161932 [details] [review] Bug 36035: Wrong text colour in addorderiso2709.pl This patch updates the "Order staged MARC records" page so that the class which is added upon selection is more unique to avoid a collision with some default DataTables styles. These classes are used in JavaScript selectors, not for visual style. The patch also adds some custom CSS variables to global.scss to override the defaults for the DataTables "selected" style, in case this issue crops up again. To test, apply the patch and rebuild the staff interface CSS. Follow the test plan from the bug report: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l 4) Save the sysprefs 5) Navigate to acquisitions and go into a basket 6) Click "Add to basket" and select "From a new file" 7) Download the file attached to this bug 8) Import the file and when the job is complete click "Add staged files to basket" 9) Click the checkbox next to the record to display the items. - The expanded form should look correct. 10) Add one or more items to the order and confirm that submitting the form works correctly. To test the new default "selected" DataTables style, view a page with a DataTable, e.g. Administration -> Libraries. - Right-click on one of the table rows and choose "Inspect" - Click the table row element, e.g. '<tr class="odd">' - Double-click the class name and replace it with "selected." - The row you inspected should now have a pale green background and text colors should remain the same. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
I'm increasing the severity and modifying the title on this one, because it's workflow-breaking that the form values are neither visible nor editable by staff. (I wish I could QA it too, but I don't understand the front-end stuff well enough to do that. =/)
Created attachment 163851 [details] [review] Bug 36035: Wrong text colour in addorderiso2709.pl This patch updates the "Order staged MARC records" page so that the class which is added upon selection is more unique to avoid a collision with some default DataTables styles. These classes are used in JavaScript selectors, not for visual style. The patch also adds some custom CSS variables to global.scss to override the defaults for the DataTables "selected" style, in case this issue crops up again. To test, apply the patch and rebuild the staff interface CSS. Follow the test plan from the bug report: 1) In system preferences, click Search and then select the Acquisitions option from the left hand menu 2) Paste the following into MarcFieldsToOrder price: 975$p quantity: 975$q budget_code: 975$h 3) Paste the following into MarcItemFieldsToOrder homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l 4) Save the sysprefs 5) Navigate to acquisitions and go into a basket 6) Click "Add to basket" and select "From a new file" 7) Download the file attached to this bug 8) Import the file and when the job is complete click "Add staged files to basket" 9) Click the checkbox next to the record to display the items. - The expanded form should look correct. 10) Add one or more items to the order and confirm that submitting the form works correctly. To test the new default "selected" DataTables style, view a page with a DataTable, e.g. Administration -> Libraries. - Right-click on one of the table rows and choose "Inspect" - Click the table row element, e.g. '<tr class="odd">' - Double-click the class name and replace it with "selected." - The row you inspected should now have a pale green background and text colors should remain the same. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.05
This is needed in 23.05 please
Backported to 23.05.x for upcoming 23.05.12