Bug 36044 - Show ISBN number of purchase suggestions on the OPAC
Summary: Show ISBN number of purchase suggestions on the OPAC
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 36274
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-08 12:55 UTC by Mirjam Vantieghem
Modified: 2024-07-25 11:18 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 36044: Show ISBN number of purchase suggestions on the OPAC (7.49 KB, patch)
2024-02-13 18:16 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36044: Show ISBN number of purchase suggestions on the OPAC (7.53 KB, patch)
2024-02-15 00:35 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36044: Show ISBN number of purchase suggestions on the OPAC (7.60 KB, patch)
2024-02-15 10:26 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mirjam Vantieghem 2024-02-08 12:55:28 UTC 
The list of submitted purchase suggestions in the OPAC patron account should also show the ISBN if this was filled in on the suggestion form.
Comment 1 Owen Leonard 2024-02-13 18:16:12 UTC 
Created attachment 162123 [details] [review]
Bug 36044: Show ISBN number of purchase suggestions on the OPAC

This patch adds output of ISBN in the table of purchase suggestions in
the OPAC.

The patch also adds some formatting markup to the output of suggestions
information to make it more compact, and corrects the label on the
suggestion titles so that they work to trigger the corresponding
checkbox.

To test, apply the patch and submit some suggestions. Include ISBN with
some requests.

Log in to the OPAC and view your suggestions. Confirm that the
information is displayed well, including ISBN.
Comment 2 David Nind 2024-02-15 00:35:56 UTC 
Created attachment 162166 [details] [review]
Bug 36044: Show ISBN number of purchase suggestions on the OPAC

This patch adds output of ISBN in the table of purchase suggestions in
the OPAC.

The patch also adds some formatting markup to the output of suggestions
information to make it more compact, and corrects the label on the
suggestion titles so that they work to trigger the corresponding
checkbox.

To test, apply the patch and submit some suggestions. Include ISBN with
some requests.

Log in to the OPAC and view your suggestions. Confirm that the
information is displayed well, including ISBN.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2024-02-15 10:26:29 UTC 
Created attachment 162193 [details] [review]
Bug 36044: Show ISBN number of purchase suggestions on the OPAC

This patch adds output of ISBN in the table of purchase suggestions in
the OPAC.

The patch also adds some formatting markup to the output of suggestions
information to make it more compact, and corrects the label on the
suggestion titles so that they work to trigger the corresponding
checkbox.

To test, apply the patch and submit some suggestions. Include ISBN with
some requests.

Log in to the OPAC and view your suggestions. Confirm that the
information is displayed well, including ISBN.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-02-15 10:26:59 UTC 
Thanks for the quick work here Owen, all looks good and QA scripts are happy.

Passing QA
Comment 5 Katrin Fischer 2024-03-07 13:27:24 UTC 
I am pretty sure that works, but wanted to test and in the OPAC I can't get the suggestion form to display. Added bug 36274.