36070 – "Place recall" hover styling on OPAC not consistent

Bug 36070 - "Place recall" hover styling on OPAC not consistent

Summary: "Place recall" hover styling on OPAC not consistent

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	OPAC (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Owen Leonard
QA Contact:	Emily Lamancusa (emlam)

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-02-12 13:04 UTC by Pedro Amorim
Modified:	2024-12-23 08:06 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.05.00,23.11.04
Circulation function:

Attachments
Bug 36070: Fix css class (1.61 KB, patch) 2024-02-12 13:05 UTC, Pedro Amorim	Details \| Diff \| Splinter Review
Bug 36070: Fix css class (1.66 KB, patch) 2024-02-12 14:38 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 36070: Fix css class (1.73 KB, patch) 2024-03-07 19:19 UTC, Emily Lamancusa (emlam)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pedro Amorim 2024-02-12 13:04:57 UTC

Comment 1 Pedro Amorim 2024-02-12 13:05:49 UTC

Created attachment 162033 [details] [review]
Bug 36070: Fix css class

1) Enable UseRecalls
2) Checkout an item to a patron:
   Top INTRA search bar: pick 'check out' and paste a patron cardnumber:
   23529000035676
   press enter
3) Enter an item barcode:
   39999000003154
   Press checkout
4) As user koha/koha, visit OPAC page for this biblio:
opac-url/cgi-bin/koha/opac-detail.pl?biblionumber=76
5) Notice all sidebar actions on the right have hover effect except for 'Place recall'

Apply patch, repeat test plan.wq

Comment 2 Owen Leonard 2024-02-12 14:38:29 UTC

Created attachment 162035 [details] [review]
Bug 36070: Fix css class

1) Enable UseRecalls
2) Checkout an item to a patron:
   Top INTRA search bar: pick 'check out' and paste a patron
   cardnumber:
   23529000035676
   press enter
3) Enter an item barcode:
   39999000003154
   Press checkout
4) As user koha/koha, visit OPAC page for this biblio:
   opac-url/cgi-bin/koha/opac-detail.pl?biblionumber=76
5) Notice all sidebar actions on the right have hover effect except for
   'Place recall'

Apply patch, repeat test plan.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Emily Lamancusa (emlam) 2024-03-07 19:19:09 UTC

Created attachment 162930 [details] [review]
Bug 36070: Fix css class

1) Enable UseRecalls
2) Checkout an item to a patron:
   Top INTRA search bar: pick 'check out' and paste a patron
   cardnumber:
   23529000035676
   press enter
3) Enter an item barcode:
   39999000003154
   Press checkout
4) As user koha/koha, visit OPAC page for this biblio:
   opac-url/cgi-bin/koha/opac-detail.pl?biblionumber=76
5) Notice all sidebar actions on the right have hover effect except for
   'Place recall'

Apply patch, repeat test plan.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Comment 4 Emily Lamancusa (emlam) 2024-03-07 19:19:50 UTC

Nice catch! Fixes the problem and QA script passes. Passing QA

Comment 5 Katrin Fischer 2024-03-08 17:59:56 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2024-03-11 10:44:48 UTC

Whooo there are a lot of FA icons without 'fa' class :

git grep 'class="fa-' -- koha-tmpl

Need to be fixed ?

Comment 7 Fridolin Somers 2024-03-11 10:45:21 UTC

Pushed to 23.11.x for 23.11.04