Not sure which spelling is correct, but consistency is good. $ grep -rn "Patron cardnumber" * koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt:4: "[% t("Manager name") | html %]"[% sep | html %]"[% t("Patron cardnumber") | html %]"[% sep | html %]"[% t("Patron name") | html %]"[% sep | html %]"[% t("Transaction library") | html %]"[% sep | html %]"[% t("Transaction date") | html %]"[% sep | html %]"[% t("Updated") | html %]"[% sep | html %]"[% t("Transaction type") | html %]"[% sep |html %]"[% t("Notes") | html %]"[% sep | html %]"[% t("Amount") | html %]"[% sep | html %]"[% t("Title") | html %]"[% sep | html %]"[% t("Barcode") | html %]"[% sep | html %]"[% t("Item type") | html %]" grep: misc/translator/po/.git/objects/pack/pack-b0a884343922aff65f857e780adda0f2bcc2203f.pack: binary file matches grep: misc/translator/po/.git/objects/pack/tmp_pack_O9fPOy: binary file matches misc/release_notes/release_notes_20_05_00.html:1588:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329">[24329]</a> Patron cardnumber change times are lost during upgrade for bug 3820</li> misc/release_notes/release_notes_20_05_00.md:1194:- [[24329]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329) Patron cardnumber change times are lost during upgrade for bug 3820 $ grep -rn "Patron card number" * koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:172: <th>Patron card number</th>
I think we should add something like this to our Terminology page (https://wiki.koha-community.org/wiki/Terminology): 'card number (noun) When referring to a patron's library card, use "card number," not "cardnumber." "cardnumber" should be used only when referring to the database column.'
Created attachment 162148 [details] [review] Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space.
Created attachment 162170 [details] [review] Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space. Signed-off-by: Magnus Enger <magnus@libriotech.no> Verified that the patch only changes "visible" text, and not references to the database column.
Created attachment 162370 [details] [review] Bug 36091: Spelling: Use "card number" instead of cardnumber in text This patch replaces the term "cardnumber" with "card number" in labels and text where the patron's library card number is referred to. Where the database column is referenced "cardnumber" is kept. A full test plan would be very time-consuming and I think examining the patch should be verification enough for changes which are limited to adding a space. Signed-off-by: Magnus Enger <magnus@libriotech.no> Verified that the patch only changes "visible" text, and not references to the database column. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Doesn't apply to 23.05.x cleanly, no baackport.