This one cannot be updated until we have a TT equivalent for <<items.fine>>. bug 17976 was filed for this a while back, but it is still in the NEW status.
Bug 17976 is now PQA, so this is no longer blocked
Created attachment 175657 [details] [review] Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are"
The test plan failed at point 12. Even if I have only 1 item checked out it still display "items are". We need to use overdues.count() and not just overdues I will to submit a follow up shortly to fix this point.
Created attachment 180573 [details] [review] Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit
Created attachment 180978 [details] [review] Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are" Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Created attachment 180979 [details] [review] Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Hi, after running 'misc/cronjobs/fines.pl -v -c', I got 'Unknown option: c' but everything else was ok ! Manu.
(In reply to Emmanuel Bétemps from comment #8) > Hi, > > after running 'misc/cronjobs/fines.pl -v -c', I got 'Unknown option: c' but > everything else was ok ! > > Manu. My bad, I must have assumed fines.pl had a -c / confirm flag when it doesn't! Thank you for testing!
Created attachment 181185 [details] [review] Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are" Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 181186 [details] [review] Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>