Bug 17975 proved that HOLD_SLIP was supported for TT syntax, and could be used as a reference for adjusting the default content.
Created attachment 165592 [details] [review] Bug 36125: Adjust default HOLD_SLIP to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Find a patron and make sure their account contains values for all of the following fields: First name Surname Card number Phone Address Address 2 City Zipcode Email 4. Place a hold for this patron, specifying a hold note 5. Check in an item to fill the hold and click "Confirm and print slip" 6. Confirm that all information on the hold slip is correct
Created attachment 165793 [details] [review] Bug 36125: Adjust default HOLD_SLIP to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Find a patron and make sure their account contains values for all of the following fields: First name Surname Card number Phone Address Address 2 City Zipcode Email 4. Place a hold for this patron, specifying a hold note 5. Check in an item to fill the hold and click "Confirm and print slip" 6. Confirm that all information on the hold slip is correct Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 165877 [details] [review] Bug 36125: (follow-up) Fix missing dollar sign
Added a follow-up to fix a typo...feel free to squash when pushing
Created attachment 166409 [details] [review] Bug 36125: Adjust default HOLD_SLIP to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Find a patron and make sure their account contains values for all of the following fields: First name Surname Card number Phone Address Address 2 City Zipcode Email 4. Place a hold for this patron, specifying a hold note 5. Check in an item to fill the hold and click "Confirm and print slip" 6. Confirm that all information on the hold slip is correct Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 166410 [details] [review] Bug 36125: (follow-up) Use $KohaDates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Hi there, happy to push as is, but I notice these are "direct" translations of our old templates. It might be nice to make them a little nicer with the added benefits of TT. For an example: This here will leave the bullet points with nothing after, when the value is not available: + - " <li>[% item.barcode %]</li>" + - " <li>[% item.itemcallnumber %]</li>" + - " <li>[% reserve.waitingdate | $KohaDates %]</li>" That's a problem now and it will persist in the new version. If we added some IF/ELSE, that might be a cool addition for a future patch.
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x