If a librarian copies a serial subscription and changes dates the Flatpickr allows to put end date to the past. Flatpickr prevents the action only if the start date is first added. In this case the old input value should be passed to the Flatpickr so the selection is not allowed. I think this happens everywhere where we are using Flatpickr.
Created attachment 183724 [details] [review] Bug 36136: Add validation to subscription end date Fixed an issue where editing an existing subscription as a duplicate would result in being able to select the end date before the start date. To test: 1)In Koha go to Serials 2)Search for existing subscriptions 3)Select a subscription 4)Select Edit, Edit as new(duplicate) 5)On the second page set the end date before the start date 6)When pressing save subscription a warning pops up, preventing you from selecting the end date before the start date. Sponsored-by: Koha-Suomi Oy
Created attachment 184377 [details] [review] Bug 36136: Make sure 'to' dates are instantiated with the 'from' dates as minimum
Sorry I don't have more time to test this patch, but the issue is global and must be fixed globally. This patch is not perfect, but it is the least invasive and won't require to add a back reference to all "to" elements.
Created attachment 184411 [details] [review] Bug 36136: Make sure 'to' dates are instantiated with the 'from' dates as minimum To test you should check the behavior of forms which have sets of "from" and "to" dates. It shouldn't be possible to select a "to" date which is before the "from" date. For example: - Overdues report - Invoice search In some cases we need to check that the fields work correctly when the "from" date is already filled: - Editing vendor issues - Editing a budget - Duplicating a subscription Signed-off-by: Owen Leonard <oleonard@myacpl.org>