Bug 36157 - Links in the "Run with template" dropdown at guided_reports.pl have odd formatting
Summary: Links in the "Run with template" dropdown at guided_reports.pl have odd forma...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Pedro Amorim
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 36156 36158
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-23 15:04 UTC by Jason Robb
Modified: 2024-03-19 15:08 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04


Attachments
Dropdown formatting differences (18.94 KB, image/png)
2024-02-23 15:04 UTC, Jason Robb
Details
Bug 36157: Remove class from anchor link (1.32 KB, patch)
2024-02-23 16:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36157: Remove class from anchor link (1.92 KB, patch)
2024-02-26 09:11 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36157: Remove class from anchor link (1.98 KB, patch)
2024-02-26 11:48 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 36157: Remove class from anchor link (2.04 KB, patch)
2024-02-29 10:26 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Robb 2024-02-23 15:04:06 UTC
Created attachment 162385 [details]
Dropdown formatting differences

When using the feature added by bug 34136, the new "Run with template" dropdown  has btn classes on the links in the dropdown list which gives it odd formatting compared to the rest of the dropdowns in the toolbar. I attached a screenshot to hopefully better illustrate.

To replicate:
- Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug:

[% FOREACH b IN data %]
<div class="panel panel-default">
  <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
  <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
  <div class="panel-footer">ID: [% b.borrowernumber %]</div>
</div>
[% END %]

- Create and run a saved report. Example from the other bug:

SELECT * FROM borrowers

- Click on the "Run with template" dropdown and hover the template title.
Comment 1 Pedro Amorim 2024-02-23 16:23:22 UTC
Created attachment 162391 [details] [review]
Bug 36157: Remove class from anchor link
Comment 2 David Nind 2024-02-23 18:58:35 UTC
Getting sha1 error when trying to apply the patch:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 36157: Remove class from anchor link
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc).
error: could not build fake ancestor
Patch failed at 0001 Bug 36157: Remove class from anchor link
hint: Use 'git am --show-current-patch=diff' to see the failed patch

Also, shouldn't the commit message be formatted according to the guidelines? (https://wiki.koha-community.org/wiki/Commit_messages)
Comment 3 Pedro Amorim 2024-02-26 09:11:17 UTC
Created attachment 162422 [details] [review]
Bug 36157: Remove class from anchor link

Test plan:
- Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136:
[% FOREACH b IN data %]
<div class="panel panel-default">
  <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
  <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
  <div class="panel-footer">ID: [% b.borrowernumber %]</div>
</div>
[% END %]

- Create and run a saved report. Example from the other bug:
SELECT * FROM borrowers

- Click on the "Run with template" dropdown and hover the template title.

- Notice it the styling of the hover. Apply patch. Repeat.
Comment 4 Kyle M Hall 2024-02-26 11:48:12 UTC
Created attachment 162429 [details] [review]
Bug 36157: Remove class from anchor link

Test plan:
- Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136:
[% FOREACH b IN data %]
<div class="panel panel-default">
  <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
  <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
  <div class="panel-footer">ID: [% b.borrowernumber %]</div>
</div>
[% END %]

- Create and run a saved report. Example from the other bug:
SELECT * FROM borrowers

- Click on the "Run with template" dropdown and hover the template title.

- Notice it the styling of the hover. Apply patch. Repeat.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Martin Renvoize 2024-02-29 10:26:50 UTC
Created attachment 162582 [details] [review]
Bug 36157: Remove class from anchor link

Test plan:
- Create a notice with the module of "Reports" -- add something to the "Print" section. Example from bug 34136:
[% FOREACH b IN data %]
<div class="panel panel-default">
  <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
  <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
  <div class="panel-footer">ID: [% b.borrowernumber %]</div>
</div>
[% END %]

- Create and run a saved report. Example from the other bug:
SELECT * FROM borrowers

- Click on the "Run with template" dropdown and hover the template title.

- Notice it the styling of the hover. Apply patch. Repeat.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-03-07 14:04:45 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-03-11 09:23:59 UTC
Pushed to 23.11.x for 23.11.04
Comment 8 Lucas Gass 2024-03-19 15:08:51 UTC
Missing 23.05.x dependencies, no backport.