Bug 36203 - Authorised value's descriptions should not be NULL
Summary: Authorised value's descriptions should not be NULL
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 34920
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-29 14:58 UTC by Jonathan Druart
Modified: 2024-03-03 23:00 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-02-29 14:58:47 UTC
We default to NULL in DB for authorised_values.lib but actually we should require a description. Or dropdown lists will have an empty option.

For the atomic update we should fix existing data and retrieve the code.
Comment 1 Jonathan Druart 2024-02-29 14:59:16 UTC
Katrin, could you confirm this assumption?
Comment 2 Katrin Fischer 2024-03-01 22:27:20 UTC
In the past it was sometimes necessary to add an empty entry manually, as the pull downs would not offer one otherwise. So such entries might exist in the existing databases for a reason. I am not sure if they are still needed.

How would a fix with the atomicupdate look like? Would we aim for deleting such entries?

I believe just removing them could cause issues: a pull down that does not offer an empty entry on its own, would jump to the first entry in list, which would result in saving/displaying wrong values in forms.