Bug 36212 - transferbook should not look for items without barcode
Summary: transferbook should not look for items without barcode
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-01 09:37 UTC by Marcel de Rooy
Modified: 2024-11-15 01:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:

Attachments
Bug 36212: Add check on barcode before searching items (1.05 KB, patch)
2024-03-01 09:41 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-03-01 09:37:29 UTC 
Circulation.t fails if you have items without barcode on transferbook tests.
See also bug 31427.
Comment 1 Marcel de Rooy 2024-03-01 09:41:49 UTC 
Created attachment 162646 [details] [review]
Bug 36212: Add check on barcode before searching items

Test plan:
Add an item to your database that has no barcode.
Run t/db_dependent/Circulation.t
It will fail without this patch, pass with this patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-03-01 09:42:53 UTC 
Trivial. This is kind of QA follow-up for getting 31427 further.
Comment 3 Katrin Fischer 2024-03-07 16:37:31 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 4 Fridolin Somers 2024-03-11 10:19:02 UTC 
Pushed to 23.11.x for 23.11.04
Comment 5 Lucas Gass (lukeg) 2024-03-19 19:58:19 UTC 
Backported to 23.05.x for upcoming 23.05.10