Bug 36270 - Remove special handling for <<borrower-attribute:CODE>>
Summary: Remove special handling for <<borrower-attribute:CODE>>
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
Depends on:
Blocks: 31510
  Show dependency treegraph
Reported: 2024-03-07 10:54 UTC by Martin Renvoize
Modified: 2024-03-22 06:51 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Bug 36270: Remove borrower-attribute:code from <<>> notices (2.17 KB, patch)
2024-03-07 11:03 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2024-03-07 10:54:35 UTC
Borrower attributes should be simple enough to fetch using TT syntax now and the special casing here for the old template syntax is a blocker for it's removal.

As this functionality is not documented anywhere and there's not any cases of it in use in the default shipped notices I think we should just remove it.
Comment 1 Martin Renvoize 2024-03-07 11:00:48 UTC
Except.. the placeholder syntax is exposed in the selection options of the editor.. so it's likely in prevalent use all over the place :(
Comment 2 Martin Renvoize 2024-03-07 11:03:02 UTC
Created attachment 162896 [details] [review]
Bug 36270: Remove borrower-attribute:code from <<>> notices

We need to replace this with a TT alternative however :|
Comment 3 Martin Renvoize 2024-03-07 11:03:40 UTC
I'm reconsidering this given comment 2
Comment 4 Katrin Fischer 2024-03-07 12:10:55 UTC
Could we provide a code example on how to achieve the same with TT?

Or is this not available at all yet? I found a bug, but couldn't dig deeper yet:

Bug 30657 - Make patron attributes available via Template Toolkit in overdues
Comment 5 Lucas Gass 2024-03-07 15:35:00 UTC
I can say that I've seen this used fairly often out in the wild.
Comment 6 Martin Renvoize 2024-03-08 14:25:51 UTC
Do you have any clues on how often it's used with repeatable attributes Lucas?
Comment 7 Lucas Gass 2024-03-09 17:56:52 UTC
(In reply to Martin Renvoize from comment #6)
> Do you have any clues on how often it's used with repeatable attributes
> Lucas?

Sorry Martin, I cannot really say with any certainty. I know I see it, but cannot say how widespread it is.
Comment 8 Anneli Österman 2024-03-22 06:51:57 UTC
<<borrower-attribute:code>> tag is used in our libraries for example in HOLD notices and HOLD_SLIP slips. We add patron's hold identifier and bookmobile stops to them with patron attributes. If this tag is removed we would need a substitute for it.