Borrower attributes should be simple enough to fetch using TT syntax now and the special casing here for the old template syntax is a blocker for it's removal. As this functionality is not documented anywhere and there's not any cases of it in use in the default shipped notices I think we should just remove it.
Except.. the placeholder syntax is exposed in the selection options of the editor.. so it's likely in prevalent use all over the place :(
Created attachment 162896 [details] [review] Bug 36270: Remove borrower-attribute:code from <<>> notices We need to replace this with a TT alternative however :|
I'm reconsidering this given comment 2
Could we provide a code example on how to achieve the same with TT? Or is this not available at all yet? I found a bug, but couldn't dig deeper yet: Bug 30657 - Make patron attributes available via Template Toolkit in overdues
I can say that I've seen this used fairly often out in the wild.
Do you have any clues on how often it's used with repeatable attributes Lucas?
(In reply to Martin Renvoize from comment #6) > Do you have any clues on how often it's used with repeatable attributes > Lucas? Sorry Martin, I cannot really say with any certainty. I know I see it, but cannot say how widespread it is.
<<borrower-attribute:code>> tag is used in our libraries for example in HOLD notices and HOLD_SLIP slips. We add patron's hold identifier and bookmobile stops to them with patron attributes. If this tag is removed we would need a substitute for it.
Bug 30657 gives you a replacement syntax for TT
A database update could be implement a find and replace I guess